Open Bug 1570499 (fallthrough) Opened 4 months ago Updated 3 months ago

Replace MOZ_FALLTHROUGH macro with C++17 attribute [[fallthrough]]

Categories

(Core :: MFBT, task, P3)

task

Tracking

()

People

(Reporter: cpeterson, Unassigned)

References

(Depends on 1 open bug)

Details

Bug 1215411 defined MOZ_FALLTHROUGH using clang's nonstandard attribute [[clang::fallthrough]]. After we compile as C++17 by default (bug 1560664), we can replace MOZ_FALLTHROUGH with C++17's standard [[fallthrough]] attribute.

https://en.cppreference.com/w/cpp/language/attributes/fallthrough

TBD whether we can then remove the MOZ_FALLTHROUGH_ASSERT macro (from bug 1235277) that works around clang bug https://llvm.org/bugs/show_bug.cgi?id=25966.

You need to log in before you can comment on or make changes to this bug.