Bug 1773611 Comment 14 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Reproduced in duplicate bug 1898648.

(In reply to Alessandro Castellani [:aleca] from comment #7)
> *If the contact was added but the recipient icon didn't update* ...

Yes, this is what happens for me, too. See detailed "actual results" in bug 1898648.

(In reply to Alessandro Castellani [:aleca] from comment #7)
> *... it means that something is not running correctly [here](https://searchfox.org/comm-central/rev/8513d87a80bff2e4eee8115e3c18c8a5dc26e3dd/mail/base/content/widgets/header-fields.js#118-132)*
> *Which is the observer that listens for changes to the contacts in the address book and it's in charge of reloading the header recipients that were recently added/removed.*

(In reply to Alessandro Castellani [:aleca] from comment #9)
> *Based on the feedback of comment 8, it seems that the contact card is created without problems, but the observer is not triggered to refresh the message header UI.
> […]
> I asked around for other people to test it and they all confirmed it works as intended. […]
> I really don't know what to do here until I can reproduce this in any way.*

Maybe it could be related to the fact that I am working on really old/slow hardware. In case the code (*"observer that listens for changes to the contacts in the address book"*) is not efficient, maybe it has not finished execution at the time when the duplicate clicks (on the user icon) arrive ? This is the only hunch I have.

You could (kind of) simulate this by simultaneously running a process (maybe with higher priority than TB) that consumes up 99% of CPU cycles. Maybe you can reproduce this bug in this situation.
Reproduced in duplicate bug 1898648.

(In reply to Alessandro Castellani [:aleca] from comment #7)
> *If the contact was added but the recipient icon didn't update* ...

Yes, this is what happens for me, too. See detailed "actual results" in bug 1898648.

(In reply to Alessandro Castellani [:aleca] from comment #7)
> *... it means that something is not running correctly [here](https://searchfox.org/comm-central/rev/8513d87a80bff2e4eee8115e3c18c8a5dc26e3dd/mail/base/content/widgets/header-fields.js#118-132)*
> *Which is the observer that listens for changes to the contacts in the address book and it's in charge of reloading the header recipients that were recently added/removed.*

(In reply to Alessandro Castellani [:aleca] from comment #9)
> *Based on the feedback of comment 8, it seems that the contact card is created without problems, but the observer is not triggered to refresh the message header UI.
> […]
> I asked around for other people to test it and they all confirmed it works as intended. […]
> I really don't know what to do here until I can reproduce this in any way.*

Maybe it could be related to the fact that I am working on really old/slow hardware. In case the code (*"observer that listens for changes to the contacts in the address book"*) is not efficient, maybe it has not finished execution at the time when the duplicate clicks (on the user icon) arrive ? This is the only hunch I have, because it sometimes takes my TB a minute or two to change the gray contact icons from gray to blue (while at other times the change happens immediately though). In those instances where the contact icons are not updated immediately, TB does NOT lag or feel unresponsive.

You could (kind of) simulate slower hardware by simultaneously running another process (maybe with higher priority than TB) that consumes up 99% of CPU cycles. Maybe you can reproduce this bug in this situation.
Reproduced in duplicate bug 1898648.

(In reply to Alessandro Castellani [:aleca] from comment #7)
> *If the contact was added but the recipient icon didn't update* ...

Yes, this is what happens for me, too. See detailed "actual results" in bug 1898648.

(In reply to Alessandro Castellani [:aleca] from comment #7)
> *... it means that something is not running correctly [here](https://searchfox.org/comm-central/rev/8513d87a80bff2e4eee8115e3c18c8a5dc26e3dd/mail/base/content/widgets/header-fields.js#118-132)*
> *Which is the observer that listens for changes to the contacts in the address book and it's in charge of reloading the header recipients that were recently added/removed.*

(In reply to Alessandro Castellani [:aleca] from comment #9)
> *Based on the feedback of comment 8, it seems that the contact card is created without problems, but the observer is not triggered to refresh the message header UI.
> […]
> I asked around for other people to test it and they all confirmed it works as intended. […]
> I really don't know what to do here until I can reproduce this in any way.*

Maybe it could be related to the fact that I am working on really old/slow hardware. In case the code (*"observer that listens for changes to the contacts in the address book"*) is not efficient, maybe it has not finished execution at the time when the duplicate clicks (on the user icon) arrive ? This is the only hunch I have, because it sometimes takes my TB a minute or two to change the contact icons from gray to blue (while at other times the change happens immediately though). In those instances where the contact icons are not updated immediately, TB does NOT lag or feel unresponsive, however.

You could (kind of) simulate slower hardware by simultaneously running another process (maybe with higher priority than TB) that consumes up 99% of CPU cycles. Maybe you can reproduce this bug in this situation.

Back to Bug 1773611 Comment 14