1773611 - Add to Address book from message header sometimes allows adding duplicate contact without feedback (contact icon remains gray)

Status: NEW

(Thunderbird :: Address Book, defect)

Description

[Jaise]

Attachment: addressbook.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

Right click / Press icon add address book. Press multiple times.

Actual results:

No feed back on address added.

Expected results:

Icon should change to blue & feed back that it is added.

Comment 1

[Jaise]

Attachment: addressbook 1.png

added multiple times.

Comment 2

[Anje]

Can you clarify what you experience regarding just the star icon.
You said:

Add to address book icon is very light colour[blue]. We will not feel, address added to address book.

But you also say:

Actual results: No feed back on address added.
Expected results: Icon should change to blue

Icon should change from an outline of star to a solid coloured star.
It is unclear from your comment whether this occurs.
Can you post images that show the star before and after adding to address book.

Sorry - forgot icon was changed - it may now look like human icon - same as used for contact in address book.

Comment 3

[Anje]

Please clarify what you experience regarding the drop down menu list items.

After adding a new email address via header for first time, you say the drop down menu will allow adding a second time.
Please post an image which shows the drop down options when you attempt to add a second time - please make sure we can see the star icon of previously added person in same image.

Comment 4

[Jaise]

(In reply to Anje from comment #2)

Can you clarify what you experience regarding just the star icon.
You said:

Add to address book icon is very light colour[blue]. We will not feel, address added to address book.

But you also say:

Actual results: No feed back on address added.
Expected results: Icon should change to blue

Icon should change from an outline of star to a solid coloured star.
It is unclear from your comment whether this occurs.
Can you post images that show the star before and after adding to address book.

I tested this in daily 103a1.

New human icon is not clear as compared to star on add to address book [personal opinion as a user]
When Right click / click on star icon, Add to Address book Blink & it is not turn to blue icon. It is stay in grey icon. If i clicked multiple times, it is added multiple to address book.
But if I change to another tab & again back this tab, star icon is blue.
It was working earlier daily version of Thunderbird.

I tested removing added address again, behavior same for me.

Comment 5

[Thomas D. (:thomas8)]

wfm on 103.0a1 (2022-06-09) (64-bit), Win10.
Clicking on grey person icon, or Right-click > Add to Address book trigger instant visual feedback, email address disappears, display name remains, icon changes to blue, title is Edit contact, also in context menu, and that's what it does. No way to add duplicate entries here.

Jaise:

1. Which OS are you on, and which exact version of 103.0a1 (incl. date)?
2. Does this happen in ≡ > Help > Troubleshoot Mode…?
3. Does this happen after unchecking ≡ > Settings > General > [ ] Use hardware acceleration when available?
4. Anything in error console (Ctrl+J) when this happens?

Comment 6

[Jaise]

Thunderbird on 103.0a1 (2022-06-09) (64-bit), Win11. mails configured in pop3 & storage is mbox.
It is happening after disabling hardware acceleration & restarted TB.

This daily TB installation is only for testing new features.

Error console is not showing any new error. Another issue is seeing Error console is not opening, if try to open second time.

Comment 7

[Alessandro Castellani [:aleca]]

I'll try to test this with a POP account.

Can you test one thing?

• Click on the icon only once to add the recipient to the address book.
• Open the Address Book and see if the contact was added.

If the contact was added but the recipient icon didn't update, it means that something is not running correctly here: https://searchfox.org/comm-central/rev/8513d87a80bff2e4eee8115e3c18c8a5dc26e3dd/mail/base/content/widgets/header-fields.js#118-132
Which is the observer that listens for changes to the contacts in the address book and it's in charge of reloading the header recipients that were recently added/removed.

Comment 8

[Jaise]

(In reply to Alessandro Castellani [:aleca] from comment #7)

I'll try to test this with a POP account.

Can you test one thing?

• Click on the icon only once to add the recipient to the address book.
• Open the Address Book and see if the contact was added.

If the contact was added but the recipient icon didn't update, it means that something is not running correctly here: https://searchfox.org/comm-central/rev/8513d87a80bff2e4eee8115e3c18c8a5dc26e3dd/mail/base/content/widgets/header-fields.js#118-132
Which is the observer that listens for changes to the contacts in the address book and it's in charge of reloading the header recipients that were recently added/removed.

contact adding is working fine.

Comment 9

[Alessandro Castellani [:aleca]]

I tested this multiple times trying to reproduce it, but no luck.

• Tested on Windows, Linux, and macOS.
• Tested with local and remote Address Book (CardDav).
• I asked around for other people to test it and they all confirmed it works as intended.

Based on the feedback of comment 8, it seems that the contact card is created without problems, but the observer is not triggered to refresh the message header UI.

I really don't know what to do here until I can reproduce this in any way.

Comment 10

[Jaise]

Attachment: Animation.gif

Comment 11

[Jaise]

Attachment: addressbook 2.png

Comment 12

[Jaise]

I tested on another machine by upgrading TB102 [window 10]. Same issue for me.

Comment 14

[chrizilla]

Reproduced in duplicate bug 1898648.

(In reply to Alessandro Castellani [:aleca] from comment #7)

If the contact was added but the recipient icon didn't update ...

Yes, this is what happens for me, too. See detailed "actual results" in bug 1898648.

(In reply to Alessandro Castellani [:aleca] from comment #7)

... it means that something is not running correctly here
Which is the observer that listens for changes to the contacts in the address book and it's in charge of reloading the header recipients that were recently added/removed.

(In reply to Alessandro Castellani [:aleca] from comment #9)

Based on the feedback of comment 8, it seems that the contact card is created without problems, but the observer is not triggered to refresh the message header UI.
[…]
I asked around for other people to test it and they all confirmed it works as intended. […]
I really don't know what to do here until I can reproduce this in any way.

Maybe it could be related to the fact that I am working on really old/slow hardware. In case the code ("observer that listens for changes to the contacts in the address book") is not efficient, maybe it has not finished execution at the time when the duplicate clicks (on the user icon) arrive ? This is the only hunch I have, because it sometimes takes my TB a minute or two to change the contact icons from gray to blue (while at other times the change happens immediately though). In those instances where the contact icons are not updated immediately, TB does NOT lag or feel unresponsive, however.

You could (kind of) simulate slower hardware by simultaneously running another process (maybe with higher priority than TB) that consumes up 99% of CPU cycles. Maybe you can reproduce this bug in this situation.

Comment 15

[chrizilla]

@Jaise: Would you describe the hardware you used in comment #0 and comment #12 as old/slow or rather modern/fast ?

Comment 16

[Jaise]

My system details
processor Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz 1.80 GHz
Ram : 8.00 GB

Currently bug is not triggering for me.

Comment 17

[chrizilla]

@Jaise: Thanks. This is the hardware you produced the bug 2 years ago, right ?
"Currently bug is not triggering for me." --> In which TB version?

Comment 18

[chrizilla]

Attachment: lost AB sync - TB forgets known contacts.gif

This information is probably related:

– Sometimes TB "forgets" known contacts (gray contact icon, no display name override in header).
– A couple of minutes later TB "remembers" this contact (contact icon turns blue, display name override in header). see attached animation

I'll give feedback after test on a current version.