It would be good to get some QA coverage of the new tab-modal user onboarding in combination with session restore sooner rather than later. One conceivable race condition; there may be others: * new tab is added by showUpgradeDialog calling addTrustedTab(about:home) * new tab is selected, modal is rendered there * a tab from previous session is restored in front of it and selected, leaving modal not visible I have no sense of whether this occurs in regular, or, if so, how frequently. It would be helpful to play with profiles that have session restore enabled, do similar QA to bug 1789008.
Bug 1789549 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
It would be good to get some QA coverage of the new tab-modal user onboarding in combination with session restore sooner rather than later. One conceivable race condition; there may be others: * new tab is added by showUpgradeDialog calling addTrustedTab(about:home) * new tab is selected, modal is rendered there * a tab from previous session is restored in front of it and selected, leaving modal not visible I have no sense of whether this actually occurs, or, if so, how frequently. It would be helpful to play with profiles that have session restore enabled, in part by doing similar QA as done on bug 1789008.
It would be good to get some QA coverage of the new tab-modal user onboarding in combination with session restore sooner rather than later. One conceivable race condition; there may be others: * new tab is added by showUpgradeDialog calling addTrustedTab(about:home) * new tab is selected, modal is rendered there * a tab from previous session is restored in front of it and selected, leaving modal not visible I have no sense of whether this actually occurs, or, if so, how frequently. To reproduce this under appropriate conditions, use the "Steps to Reproduce" in https://bugzilla.mozilla.org/show_bug.cgi?id=1789008 , but instead of opening just wikipedia, open a bunch of pages.
It would be good to get some QA coverage of the new tab-modal user onboarding in combination with session restore sooner rather than later. One conceivable race condition; there may be others: * new tab is added by showUpgradeDialog calling addTrustedTab(about:home) * new tab is selected, modal is rendered there * a tab from previous session is restored in front of it and selected, leaving modal not visible I have no sense of whether this actually occurs, or, if so, how frequently. To reproduce this under appropriate conditions, use the "Steps to Reproduce" in https://bugzilla.mozilla.org/show_bug.cgi?id=1789008 , but instead of opening just wikipedia, open a bunch of pages, possibly across multiple windows.
It would be good to get some QA coverage of the new tab-modal user onboarding in combination with session restore sooner rather than later. One conceivable race condition; there may be others: * new tab is added by showUpgradeDialog calling addTrustedTab(about:home) * new tab is selected, modal is rendered there * a tab from previous session is restored in front of it and selected, leaving modal not visible I have no sense of whether this actually occurs, or, if so, how frequently. To reproduce this under appropriate conditions, use the "Steps to Reproduce" in https://bugzilla.mozilla.org/show_bug.cgi?id=1789501 , but instead of opening just wikipedia, open a bunch of pages, possibly across multiple windows.