1789549 - verify that existing user onboarding works with session restore

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P2)

Description

[Dan Mosedale (:dmosedale, :dmose)]

It would be good to get some QA coverage of the new tab-modal user onboarding in combination with session restore sooner rather than later.

One conceivable race condition; there may be others:

• new tab is added by showUpgradeDialog calling addTrustedTab(about:home)
• new tab is selected, modal is rendered there
• a tab from previous session is restored in front of it and selected, leaving modal not visible

I have no sense of whether this actually occurs, or, if so, how frequently.

To reproduce this under appropriate conditions, use the "Steps to Reproduce" in https://bugzilla.mozilla.org/show_bug.cgi?id=1789501 , but instead of opening just wikipedia, open a bunch of pages, possibly across multiple windows.

Comment 1

[Marius Coman [:mcoman], Ecosystem QA]

Hi, Dan! We have already created the Test Case to cover the above scenarios. You can find them here.

Could you please review them to verify that all the information is correct and that we have covered all the important scenarios?

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Thanks for the link, Marius. I found these test cases, which all seem more or less identical:

https://testrail.stage.mozaws.net/index.php?/cases/view/1359510
https://testrail.stage.mozaws.net/index.php?/cases/view/1332830
https://testrail.stage.mozaws.net/index.php?/cases/view/1326923
https://testrail.stage.mozaws.net/index.php?/cases/view/1326922
https://testrail.stage.mozaws.net/index.php?/cases/view/1608419

While they do technically test that the dialog works correctly with that setting set, it seems like they don't cover the (probably somewhat more common in the wild) cases where there are a few tabs open, and a bunch of tabs open, possibly across multiple windows, which are the things that are more likely to trigger race conditions, I'd expect. It seems like a cases for those situations would add to our confidence meaningfully.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

The pointer to steps to reproduce that I had in comment 1 was incorrrect, and I've now fixed that. The bug with the detailed steps to reproduce is https://bugzilla.mozilla.org/show_bug.cgi?id=1789501.

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

Hi, Dan! It seems that the TestRail link from my previous comment redirects to the whole test suite instead of the specific test cases (sorry for that). I will leave individual links for the test cases below:

https://testrail.stage.mozaws.net/index.php?/cases/view/1903452
https://testrail.stage.mozaws.net/index.php?/cases/view/1903456
https://testrail.stage.mozaws.net/index.php?/cases/view/1903457
https://testrail.stage.mozaws.net/index.php?/cases/view/1903458
https://testrail.stage.mozaws.net/index.php?/cases/view/1903459
https://testrail.stage.mozaws.net/index.php?/cases/view/1903605
https://testrail.stage.mozaws.net/index.php?/cases/view/1909029

Please review them in order to verify if we covered all the scenarios you have mentioned. Also, we have added these test cases to our Onboarding test suite, and will be covered during the current Nightly testing.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

@mcoman: those look great; thanks! Since you've added them in a way that they will be covered during currently Nightly testing, I'm going resolve this as fixed.

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

This task was part of the testing performed in the Nightly checkpoint phase for which we sent a GREEN checkpoint status. Considering this I am marking this as Verified.