1789008 - switch Onboarding Messaging Provider from window-modal to tab-modal

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Ania, Ed, Gabrielle and I met today about whether to switch the onboarding dialog from window-modal to tab-modal. We put together a (still being edited!) risk register, and the decision was made to forward with the switch, in part because it will be easy to back out if something goes sideway.s

The acceptance criteria are (at least):

1. onboarding modal is opened as tab-modal
2. opens over a new tab containing Firefox Home (about:home)
3. new tab is placed (ideally) next to the last used tab, otherwise at the end of the tab strip

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1789008 - make onboarding tab modal in new tab instead of window modal,r=Mardak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5618f2af1761
make onboarding tab modal in new tab instead of window modal,r=Mardak

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/5618f2af1761

Comment 4

[Marius Coman [:mcoman], Ecosystem QA, PTO until 20th of October, for any testing requests ping :poiegas]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (106.0a1 Build ID - 20220905214329) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64. Now, I can confirm the following:

• The Onboarding modal is opened as a tab modal.
• The Onboarding is displayed on a new tab containing the "about:home" page.
• The new tab is opened next to the last used tab regardless of its position.
• If a pinned tab is the last used tab, the "about:home" tab containing the Onboarding modal will be opened at the beginning of the Tab Strip regardless if we have only pinned tabs opened or pin and regular tabs.