Bug 1835559 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I added a unit test in bug 1835561, but skipped the test for the `internalError` element (in an if) because of this bug. To run the test, do:

```
./mach test toolkit/mozapps/update/tests/browser/browser_aboutDialog_AppUpdater_stop_internal_error.js
```

While working on that, I noticed that if I delete the `update-manual` message (i.e. revert the fix from bug 1835561), then the test passes.
Could it be that the presence of `<label data-l10n-name="manual-link"/>` somehow causes the second link to lose its text content?

On the Nightly where I reproduced this bug, the `update-manual` message was already missing (because bug 1820654 deleted it). So this might be unrelated or test-only.
Revision 1 by
on 
I added a unit test in bug 1835561, but skipped the test for the `internalError` element (in an if) because of this bug. To run the test, do:

```
./mach test toolkit/mozapps/update/tests/browser/browser_aboutDialog_AppUpdater_stop_internal_error.js
```

While working on that, I noticed that if I delete the `update-manual` message (i.e. revert the fix from bug 1835561), then the test passes.
Could it be that the presence of `<label data-l10n-name="manual-link"/>` somehow causes the second link to lose its text content?

On the Nightly where I reproduced this bug, the `update-manual` message was already missing (because bug 1820654 deleted it). So this might be unrelated or test-only.

---

When I don't skip the check from the patch to bug 1835561, then the test fails with:

```
toolkit/mozapps/update/tests/browser/browser_aboutDialog_AppUpdater_stop_internal_error.js
  FAIL The panel's link should have non-empty textContent, got "" -
Stack trace:
chrome://mochikit/content/browser-test.js:test_ok:1582
chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:assertNonEmptyText:836
chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutDialogUpdateTest/processAboutDialogStep/<:838
chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:processAboutDialogStep:866
chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutDialogUpdateTest/<:932
chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutDialogUpdateTest:934
chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/browser_aboutDialog_AppUpdater_stop_internal_error.js:aboutDialog_AppUpdater_stop_internal_error:34
```
Revision 2 by
on 
I added a unit test in bug 1835561, but skipped the test for the `internalError` element (in an if) because of this bug. To run the test, do:

```
./mach test toolkit/mozapps/update/tests/browser/browser_aboutDialog_AppUpdater_stop_internal_error.js
```

While working on that, I noticed that if I delete the `update-manual` message (i.e. revert the fix from bug 1835561), then the test passes.
Could it be that the presence of `<label data-l10n-name="manual-link"/>` somehow causes the second link to lose its text content? EDIT: I renamed `manual-link` to `manual-link-2` and it did not fix it.

On the Nightly where I reproduced this bug, the `update-manual` message was already missing (because bug 1820654 deleted it). So this might be unrelated or test-only.

---

When I don't skip the check from the patch to bug 1835561, then the test fails with:

```
toolkit/mozapps/update/tests/browser/browser_aboutDialog_AppUpdater_stop_internal_error.js
  FAIL The panel's link should have non-empty textContent, got "" -
Stack trace:
chrome://mochikit/content/browser-test.js:test_ok:1582
chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:assertNonEmptyText:836
chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutDialogUpdateTest/processAboutDialogStep/<:838
chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:processAboutDialogStep:866
chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutDialogUpdateTest/<:932
chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runAboutDialogUpdateTest:934
chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/browser_aboutDialog_AppUpdater_stop_internal_error.js:aboutDialog_AppUpdater_stop_internal_error:34
```

Back to Bug 1835559 Comment 1