1820654 - Replace the label link under "manualUpdate" with html:a element

Status: RESOLVED FIXED

(Firefox :: Settings UI, task, P3)

Description

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • You'll need to add status = 5 before this switch statement in aboutDialog-appUpdater.js
   • You'll need to navigate to about:preferences and scroll down to the Nightly Updates section or search for "updates" in the search bar.
   • You'll need to replace this "https://nightly.mozilla.org/" <label> element with a <html:a> element. Note, you have to use <html:a> in this context because it is a XUL document and not a HTML document.
   • You may also need to update this Fluent file and replace the <label> with <html:a> if the link does not receive the correct text when the <html:a> is swapped in.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and verify your changes by making sure the link navigates correctly to "https://nightly.mozilla.org". Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 1

[Afolabi]

please can you assign this to me

Comment 2

[Lila]

Hi Tim, I am looking into this bug and interested in working on the next steps.

Comment 3

[ozisadiqkasai]

I will like to work on this bug

Comment 4

[pratikaswani9333]

Can I work on this issue?

Comment 5

[anayocrescent2]

Attachment: Bug 1820654 - Replace the label link under manualUpdate with html:a element r?tgiles

Depends on D173408

Comment 6

[anayocrescent2]

please the assignee said i should work on this

Comment 7

[anayocrescent2]

this bug is pushing me around unexpectedly , i have figured out the necessary changes thanks to help from @aria, but there is changing ftl label to html is passing build and leaving it as label also result in manualUpdate not working as expected,

I would appreciate if the reviewer can look into it.

Comment 8

[anayocrescent2]

Attachment: Bug 1820654 - Replace the label link under manualUpdate with html element. r?tgiles

Comment 9

[Tim Giles [:tgiles]]

Attachment: Bug 1820654 - Migrate string after changing markup in string. r=flod

Depends on D175011

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/753a6e3c83e1
Replace the label link under manualUpdate with html element. r=tgiles,flod
https://hg.mozilla.org/integration/autoland/rev/27155fbfd0e5
Migrate string after changing markup in string. r=flod

Comment 11

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_aboutPrefs_fc_check_cantApply.js

Backout link

Push with failures

Failure log

Comment 12

[Tim Giles [:tgiles]]

redirecting NI as a reminder to fix this, seems a bit out of scope for good-first-bug

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d006951e2b2
Replace the label link under manualUpdate with html element. r=tgiles,flod,application-update-reviewers,bytesized
https://hg.mozilla.org/integration/autoland/rev/d9887594633c
Migrate string after changing markup in string. r=flod

Comment 14

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/4d006951e2b2
https://hg.mozilla.org/mozilla-central/rev/d9887594633c