1835561 - [fluent] Missing message in locale en-US: update-manual aboutDialog.xhtml

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Rob Wu [:robwu]]

On Nightly, click the "About Nightly" dialog to check for updates. Then look at the Browser Console. It contains the following warnings:

[fluent] Missing message in locale en-US: update-manual aboutDialog.xhtml
[fluent] Couldn't find a message: update-manual aboutDialog.xhtml
[dom/l10n] Could not complete initial document translation. aboutDialog.xhtml

It looks like the message was deleted in bug 1820654 but update-manual is used here and should be brought back:
https://searchfox.org/mozilla-central/rev/f4d3fe187cf7dffa4c13b354bbde9bc47b5ccd3f/browser/base/content/aboutDialog.xhtml#91

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1820654

:anayocrescent2, since you are the author of the regressor, bug 1820654, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Rob Wu [:robwu]]

This is non-trivial. I'll attach a patch.

Comment 3

[Rob Wu [:robwu]]

Attachment: Bug 1835561 - Restore update-manual message + add test

Comment 4

[Rob Wu [:robwu]]

Attachment: Bug 1835561 - Add migration for update-manual message

update-manual was deleted when aboutdialog-update-manual was introduced,
which itself was derived from "update-manual".

The message should not have been deleted, this restores the message,
by doing the opposite of what bug_1820654_update_manual.py did.

Comment 5

[:Gijs (he/him)]

Uh, should we back out the regressing bug for 114, which we're about to ship (RC is being built today or was built yesterday, AIUI) ?

I assume this is user-facing (ie missing text) if they hit the manual update case?

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

We built and shipped our RC yesterday. I just tried the steps in both nightly and the RC and I can't reproduce the errors in the logs nor do I see obvious missing strings in the About dialog window. Is that a platform specific bug maybe? (I am on Linux)

Edit: I am seeing the warnings in the console in an en-US build, but not in an fr build

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a760f858e946
Restore update-manual message + add test r=application-update-reviewers,nalexander,fluent-reviewers,flod

Comment 8

[Rob Wu [:robwu]]

(In reply to Pascal Chevrel:pascalc from comment #6)

We built and shipped our RC yesterday. I just tried the steps in both nightly and the RC and I can't reproduce the errors in the logs nor do I see obvious missing strings in the About dialog window. Is that a platform specific bug maybe? (I am on Linux)

Edit: I am seeing the warnings in the console in an en-US build, but not in an fr build

I see the update-manual string in the fr langpack for 114.0.20230529.85652 (crxviewer for update-manual). I don't know why it's there when it was removed from en-US.
Flod mentioned that the translation is still present in all l10n repositories (https://phabricator.services.mozilla.com/D179320#5917838), so I'm going to land the fix (and request uplift) without landing the second "Fluent migration" follow-up patch.

Comment 9

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: image.png

Hello!
I can see the warnings mentioned in comment 0 after opening the Application Menu > Help > About Nightly with Firefox 115.0a1 (2023-05-29) en-US on Windows 10x64, macOS 12, and Ubuntu 20.04. The warnings are displayed each time the About dialog is opened.

The warnings are not displayed when opening the About Firefox dialog with Firefox 114.0 (20230529085652) en-US on Windows 10x64, macOS 12, or Ubuntu 20.04. Also, I cannot observe any obvious missing strings in the About dialog window. Attached a screenshot.
If more information is needed please let me know.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Rob, will there be an actual functional regression experienced by end-users on the release channel or is the log spam in the console the only side effect of this bug for end-users? Given that this is a P1/S2 I am trying to understand if this is a release blocker and if we need to uplift a fix asap and rebuild our Release Candidate. Thanks.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

If this is indeed a release blocker, can we back out safely from mozilla-release from a code and l10n POV? (adding a needinfo to flod for the l10n impact)

Comment 12

[Francesco Lodolo [:flod]]

I think it might be safer for localization to uplift this than backing out the original patch (the string is still there).

With that said, I don't think this has a practical impact for users, only a warning displayed in console.

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Francesco Lodolo [:flod] from comment #12)

I think it might be safer for localization to uplift this than backing out the original patch (the string is still there).

With that said, I don't think this has a practical impact for users, only a warning displayed in console.

Gijs, is that still a S2 given flod's evaluation of the impact? I do have an RC2 planned for today/tomorrow for another bug but I would prefer to uplift ride-alogns that have already landed in Nightly. Could we uplift into the planned dot release mid-cycle instead?

Comment 14

[:Gijs (he/him)]

(In reply to Francesco Lodolo [:flod] from comment #12)

With that said, I don't think this has a practical impact for users, only a warning displayed in console.

I'm confused. If the string is missing it's not displayed, so presumably we display nothing in its place, if/when users hit the "manual update" case. Am I missing something there?

Comment 15

[Francesco Lodolo [:flod]]

(In reply to :Gijs (he/him) from comment #14)

(In reply to Francesco Lodolo [:flod] from comment #12)

With that said, I don't think this has a practical impact for users, only a warning displayed in console.

I'm confused. If the string is missing it's not displayed, so presumably we display nothing in its place, if/when users hit the "manual update" case. Am I missing something there?

No, faulty memory on my side. We are not showing the string with the manual link to download, so there is user impact.

P.S. I think we are showing the string in the app menu, which is what confused me

Comment 16

[:Gijs (he/him)]

Attachment: Mising message

Missing manual download message and link.

Comment 17

[:Gijs (he/him)]

(In reply to Pascal Chevrel:pascalc from comment #13)

(In reply to Francesco Lodolo [:flod] from comment #12)

I think it might be safer for localization to uplift this than backing out the original patch (the string is still there).

With that said, I don't think this has a practical impact for users, only a warning displayed in console.

Gijs, is that still a S2 given flod's evaluation of the impact? I do have an RC2 planned for today/tomorrow for another bug but I would prefer to uplift ride-alogns that have already landed in Nightly. Could we uplift into the planned dot release mid-cycle instead?

So this would affect users that open the about dialog when for whatever reason the update system has decided that they need to manually download a new version (ie automated update doesn't quite work for whatever reason). They would not see any message in the window telling them what to do. I've attached a simulated screenshot of this in nightly.

Off-hand it doesn't look like we have telemetry for the about window. I don't know how many users see the manual update flow on average, and how many would see the menu (which as flod said will work) and how many would encounter this in the about dialog. non-en-US users look like they won't be affected. So perhaps based on all this it's OK to wait for the dot release? I think this is up to release drivers. :-)

Comment 18

[:Gijs (he/him)]

Meant to needinfo for my previous comment. :-)

Comment 19

[Pascal Chevrel:pascalc (PTO until April 26)]

Given that we have a respin planned, I could wait a few hours to make sure it doesn't get backed out and take this patch as a ride-along

Comment 20

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a760f858e946

Comment 21

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9336327 [details]
Bug 1835561 - Restore update-manual message + add test

Beta/Release Uplift Approval Request

• User impact if declined: Broken upgrade feature in some cases for en-US builds
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Restore a string in en-US locale
• String changes made/needed: yes
• Is Android affected?: No

(I added the uplift request myself as I need to land the patch to the branch asap for RC2)

Comment 22

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9336327 [details]
Bug 1835561 - Restore update-manual message + add test

Approved for our RC2

Comment 23

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-release/rev/d188f601a841

Comment 24

[Alexandru Trif, Desktop QA [:atrif]]

Hello! I tried reproducing this today but I don’t know what steps should I use in order to do this. I’m not sure which update message should be displayed from the screenshot from comment 16. I have also seen the snippet from bug 1835559, description but I think the message may be different from the screenshot from comment 16. At least with that snippet on an affected build only the link is missing and the Unable to check for updates due to internal error. Updates available at message is displayed and in the comment 16 screenshot, there is no message displayed.

I have also verified that the warning messages stated in comment 0 are no longer displayed in the browser console when opening App Menu > Help > About Firefox/ Nightly with Firefox 114.0 RC2 (20230530221313) and Firefox 115.0a1 (20230530213234) on Windows 10x64, macOS 12 and Ubuntu 20.04. However, these warning messages were displayed only on the Nightly affected builds and not on 114.0RC1

Are there any manual steps that can be used in order to properly reproduce/ verify this? Thank you in advance.

Comment 25

[Rob Wu [:robwu]]

To manually verify whether the message is there, run the following snippet from the Browser Console:
Services.wm.getEnumerator("Browser:About").getNext().document.querySelectorAll(".manualLink")[0].parentNode.innerHTML

On my (old) Nightly that's affected, the output is:
' <label xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" class="manualLink text-link" is="text-link" data-l10n-name="manual-link" href="https://www.mozilla.org/en-US/firefox/nightly/?reason=manual-update">https://www.mozilla.org/en-US/firefox/nightly/</label> '

On Release (without the regression, Firefox 113), the output is:
'Updates available at <label xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" class="manualLink text-link" is="text-link" data-l10n-name="manual-link" href="https://www.mozilla.org/en-US/firefox/new?reason=manual-update"/>'

Comment 26

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest RC and Nightly builds.
Thank you for the Browser Console snippet @Rob Wu. I will update the flags for this issue.