hey, :royang! This bug is a regression after the added splash screen [animation](https://bugzilla.mozilla.org/show_bug.cgi?id=1842890). When I was initially implementing Splash screen, it took me a while to understand how different versions handle splash screen lib. Basically, there are brackets of versions 21-22 (show only background), 23 (show only png), 24-26 (xml support), 27-30 (theming support), 31+ (animated xml support). Hence, the implementation was to ignore 21-22, provide png to 23, and use xml for the rest. I see three approaches we could take here: 1. Use the new animated icon only for versions that support the animated icon and keep the app icon for the older versions (<30). 2. Try using the animated icon as a static one through 24-30 api. 3. Ask for logo png for the API23 (they are x3 of the app icon size) or drop support of the API. If I can help in any way, please let me know! Also, I am up for a review.
Bug 1844261 Comment 2 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
hey, :royang! This bug is a regression after the added splash screen [animation](https://bugzilla.mozilla.org/show_bug.cgi?id=1842890). When I was initially implementing Splash screen, it took me a while to understand how different versions handle splash screen lib. Basically, there are brackets of versions 21-22 (show only background), 23 (show only png), 24-26 (xml support), 27-30 (theming support), 31+ (animated xml support). Hence, the implementation was to ignore 21-22, provide png to 23, and use xml for the rest. I see three approaches we could take here: 1. Use the new animated icon only for versions that support the animated icon and keep the app icon for the older versions (<30). 2. Try using the animated icon as a static one through 24-30 api. 3. Ask for logo png for the API23 (they are x3 of the app icon size) or drop support of the API. If I can help in any way, please let me know! Also, I am up for a review. FYI: the splash screen night style has a different parent that uses different icon size (its a bit bigger) and doesn't support icon background