1844261 - [Splash screen] empty screen on start and flickering background

Status: RESOLVED FIXED

(Fenix :: Onboarding, defect, P2)

Description

[Mike a [:mavduevskiy]]

Attachment: download23.webm

Steps to reproduce

1. Launch the app on a device in the brackets 21-23 and 24-30

Expected behavior

The will be a static splash screen on a background.

Actual behavior

Versions 21-23 have transparent screen instead of a splash screen, visually creating a delay before the launch of the app.
Versions 24-30 have an inconsistently switching black and white background during the splash screen.

Any additional information?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1842890

:royang, since you are the author of the regressor, bug 1842890, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Mike a [:mavduevskiy]]

hey, :royang! This bug is a regression after the added splash screen animation.

When I was initially implementing Splash screen, it took me a while to understand how different versions handle splash screen lib. Basically, there are brackets of versions 21-22 (show only background), 23 (show only png), 24-26 (xml support), 27-30 (theming support), 31+ (animated xml support).
Hence, the implementation was to ignore 21-22, provide png to 23, and use xml for the rest.

I see three approaches we could take here:

1. Use the new animated icon only for versions that support the animated icon and keep the app icon for the older versions (<30).
2. Try using the animated icon as a static one through 24-30 api.
3. Ask for logo png for the API23 (they are x3 of the app icon size) or drop support of the API.

If I can help in any way, please let me know! Also, I am up for a review.

FYI: the splash screen night style has a different parent that uses different icon size (its a bit bigger) and doesn't support icon background

Comment 3

[Roger Yang [:royang]]

I'm not sure if it's worth the time for us to fix older Android versions. The way our animated splash screen is now implemented, we are following the Android Splash Screen API. Is the behaviour (simlar to what you recorded here) needs a fix? It's not a great experience but it doesn't need a workaround at the same time.

Comment 4

[Roger Yang [:royang]]

I've updated the severity to S4 "minor significance, cosmetic issues, low or no impact to users". Since this is only a cosmetic issue.

Comment 5

[Roger Yang [:royang]]

I think first thing we need to confirm is to try it on a real device to see the behaviour as well. I am assuming the recording is done on an emulator and we can't be sure on a real device it's better or worse.

Comment 6

[Roger Yang [:royang]]

I think the fix here is to not use transparent as the background and icon background. Use the layer1 color
<item name="windowSplashScreenBackground">@color/fx_mobile_layer_color_1</item>
<item name="windowSplashScreenIconBackgroundColor">@color/fx_mobile_layer_color_1</item>

Comment 7

[Roger Yang [:royang]]

Attachment: device-2023-07-19-135534.webm

This is what I get by removing the transparent background and icon background. I'll make this change when updating to the new animation.

Comment 8

[Mike a [:mavduevskiy]]

Hi, Ryan! Just to clarify, did you find the issue in the latest beta build?

This patch was aiming to fix the issue, and the testing team verified today that 116.0b8 is free of this issue.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

No, but that dependency should have been set in this bug then :)

Comment 10

[Mike a [:mavduevskiy]]

:RyanVM
sorry about that! I was actually waiting for an approval from QA team who could verify the fix on real devices, and it so happened that you got to this ticket earlier than I did :)

Comment 11

[Mira Lobontiu (Android QA)]

Attachment: nightly on Android 5.0.2.mp4

This is not fixed yet on Xiaomi mi4i with Android 5.0.2 (API 21), and Huawei MediaPad M2 with Android 5.1.1 (API 22) - see the attached short video - a white blank screen is displayed on both Nightly 117.0a1 from 7/28, and Beta 116.0b8.

On LG Nexus 5 with Android 6.0.1 (API 23), and Sony Xperia Z5 Premium with Android 7.1.1 (API 25) the logo is displayed on both Nightly 117.0a1 from 7/28, and Beta 116.0b8.

Comment 12

[Mike a [:mavduevskiy]]

Mira, it is to be expected, it is the limitation of the Splash screen library.
I wonder why the splash screen was shown for 10 seconds? The experiment should not be running on the older versions