1842890 - Add splash screen animation

Status: VERIFIED FIXED

(Fenix :: Onboarding, enhancement)

Description

[Roger Yang [:royang]]

Add animated splash screen to first run users.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1842890 - Add splash screen animation (#2855)

Comment 2

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/5c6d56c352c059806ae0e9c7ad829e421d22df3a
[main] Bug 1842890 - Add splash screen animation

Comment 3

[BMO Github Automation]

Authored by https://github.com/rvandermeulen
https://github.com/mozilla-mobile/firefox-android/commit/d9ac231b1804296c61c62788a32e8b87cb14ea94
[main] Revert "Bug 1842890 - Add splash screen animation" for breaking gradle-dependencies jobs.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing Fenix gradle-dependencies job bustage.
https://github.com/mozilla-mobile/firefox-android/commit/d9ac231b1804296c61c62788a32e8b87cb14ea94

Log:
https://firefox-ci-tc.services.mozilla.com/tasks/UpXRtaRYRuaYlMjBg4SLlA/runs/5/logs/public/logs/live.log

org.mozilla.fenix.app-mergeFenixBenchmarkResources-179:/values/values.xml:9599: error: resource drawable/animated_splash_screen (aka org.mozilla.fenix:drawable/animated_splash_screen) not found.
org.mozilla.fenix.app-mergeFenixBenchmarkResources-179:/values/values.xml:9599: error: resource drawable/animated_splash_screen (aka org.mozilla.fenix:drawable/animated_splash_screen) not found.
org.mozilla.fenix.app-mergeFenixBenchmarkResources-179:/values-night-v8/values-night-v8.xml:93: error: resource drawable/animated_splash_screen (aka org.mozilla.fenix:drawable/animated_splash_screen) not found.
org.mozilla.fenix.app-mergeFenixBenchmarkResources-179:/values-night-v8/values-night-v8.xml:93: error: resource drawable/animated_splash_screen (aka org.mozilla.fenix:drawable/animated_splash_screen) not found.

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1842890 - Add splash screen animation (#2895)

Comment 6

[Roger Yang [:royang]]

Thanks, I'll investigate and re-land.

Comment 7

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/d2174b787b33b6d7daf1633ff2f048412631cb43
[main] Bug 1842890 - Add splash screen animation

Comment 8

[Andrei Mocirean]

Verified as fixed on the latest Nightly (117.0a1) from 19th of July 2023.
Device used: Google Pixel 7 Pro (Android 14)

Comment 9

[Daniel Holbert [:dholbert]]

(In reply to Roger Yang [:royang] from comment #0)

Add animated splash screen to first run users.

Clarification from slack discussion, to answer a question that came up in my mind when I filed a related bug:
This animation is actually intended to play (and does play) on every launch of the app. It's just a bit longer for first run.

Comment 10

[Roger Yang [:royang]]

Comment on attachment 9344437 [details] [review]
[mozilla-mobile/firefox-android] Bug 1842890 - Add splash screen animation (#2895)

Beta/Release Uplift Approval Request

• User impact if declined: No animated splash screen
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a change only for splash screen animation.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1842890 - Add splash screen animation (backport #2895) (#2934)

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9344437 [details] [review]
[mozilla-mobile/firefox-android] Bug 1842890 - Add splash screen animation (#2895)

Approved for Mobile 116.0b8

Comment 13

[Dianna Smith [:diannaS]]

Comment on attachment 9344944 [details] [review]
[mozilla-mobile/firefox-android] Bug 1842890 - Add splash screen animation (backport #2895) (#2934)

switching flag on the backport

Comment 14

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/b35210dd3dbf82ac798a2163d8c5ba812f191898
[releases_v116] Bug 1842890 - Add splash screen animation (#2934)

Comment 15

[Lorand Janos]

Verified as fixed on the latest Beta 116.0b8.
The splash screen animation is present on devices with Android 12 and above.
Devices used:

• Oppo Find X5 (Android 13).
• Samsung Galaxy S22 Ultra (Android 13).

Marking the ticket as verified for 116 as well.