Bug 1867336 Comment 13 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: Shopping sidebar opt-in card will be truncated on macOS, see [comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1865351#c14) for issue

Sorry for the double beta uplift req, unsure if it needs another one since the original got backed out.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: In about:config ensure:
 `browser.shopping.experience2023.active` is set to true `browser.shopping.experience2023.enabled` is set to true
`browser.shopping.experience2023.optedIn` is set to 0
- Route to amazon.com
- Notice the opt-in shopping sidebar is not truncated on macOS (and all OS)
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: A small change to the styling to use a static width for the sidebar instead of a relative one to ensure consistency across OSs.
* **String changes made/needed**: 
* **Is Android affected?**: No
Revision 1 by
on 
(Sorry for the double beta uplift req, unsure if it needs another one since the original got backed out! see [comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1867336#c10))

### Beta/Release Uplift Approval Request
* **User impact if declined**: Shopping sidebar opt-in card will be truncated on macOS, see [comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1865351#c14) for issue
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: In about:config ensure:
 `browser.shopping.experience2023.active` is set to true `browser.shopping.experience2023.enabled` is set to true
`browser.shopping.experience2023.optedIn` is set to 0
- Route to amazon.com
- Notice the opt-in shopping sidebar is not truncated on macOS (and all OS)
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: A small change to the styling to use a static width for the sidebar instead of a relative one to ensure consistency across OSs.
* **String changes made/needed**: 
* **Is Android affected?**: No
Revision 2 by
on 
(Sorry for the double beta uplift req, unsure if it needs another one since the [original got backed](https://lando.services.mozilla.com/D195015/) out! see [comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1867336#c10))

### Beta/Release Uplift Approval Request
* **User impact if declined**: Shopping sidebar opt-in card will be truncated on macOS, see [comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1865351#c14) for issue
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: In about:config ensure:
 `browser.shopping.experience2023.active` is set to true `browser.shopping.experience2023.enabled` is set to true
`browser.shopping.experience2023.optedIn` is set to 0
- Route to amazon.com
- Notice the opt-in shopping sidebar is not truncated on macOS (and all OS)
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: A small change to the styling to use a static width for the sidebar instead of a relative one to ensure consistency across OSs.
* **String changes made/needed**: 
* **Is Android affected?**: No
Revision 3 by
on 
(Sorry for the double beta uplift req, unsure if it needs another one since the [original got backed](https://lando.services.mozilla.com/D195015/) out! see [comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1867336#c10) for context)

### Beta/Release Uplift Approval Request
* **User impact if declined**: Shopping sidebar opt-in card will be truncated on macOS, see [comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1865351#c14) for issue
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: No
* **Needs manual test from QE?**: Yes
* **If yes, steps to reproduce**: In about:config ensure:
 `browser.shopping.experience2023.active` is set to true `browser.shopping.experience2023.enabled` is set to true
`browser.shopping.experience2023.optedIn` is set to 0
- Route to amazon.com
- Notice the opt-in shopping sidebar is not truncated on macOS (and all OS)
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: A small change to the styling to use a static width for the sidebar instead of a relative one to ensure consistency across OSs.
* **String changes made/needed**: 
* **Is Android affected?**: No

Back to Bug 1867336 Comment 13