1865351 - The Review Checker's Onboarding card will not show the scrollbar when resized to a smaller size

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P3)

Description

[Rares Doghi, Desktop QA]

Attachment: 2023-11-17_16h40_51.png

Affected versions

• Nightly 121.0a1 (2023-11-17)

Affected platforms

• ALL

Preconditions:
browser.shopping.experience2023.enabled - true
browser.shopping.experience2023.optedIn = 0

Steps to reproduce

1. Reach https://www.amazon.com/Lufeiya-Shelves-L-Shaped-Computer-Charging/dp/B0BZ7YD7QS/ref=sr_1_1_sspa?keywords=desk&qid=1700231995&sr=8-1-spons&sp_csd=d2lkZ2V0TmFtZT1zcF9hdGY&th=1
2. Resize the Review checker sidebar to a smaller size.

Expected result

• The Content from the card should create a scrollbar in order to be properly displayed.

Actual result

• Half of the Review checker sidebar is pushed to the right side of the window.

Regression range
Not Applicable

Comment 1

[Rares Doghi, Desktop QA]

I wasnt sure if I should leave 120 affected or disabled since this is a new feature related to the Review Checker sidebar. The ability to resize the shopping sidebar has been implemented with Bug 1858462.

Comment 2

[Jonathan Epstein]

:wrocklin Given that sidebar will load at its default size when the onboarding card loads, care to make a call on priority on this one?

Comment 3

[wrocklin]

Hey @[e-mail] To answer your question, can you provide more context on this part of your comment: "Given that sidebar will load at its default size when the onboarding card loads"? By "default size" do you mean whatever size the user has their browser set at?

Question for [e-mail] - to confirm, are you proposing there should be a horizontal scrollbar here? (vs. a vertical one?)

Zooming out for a second, given the initial data shows users currently onboard at a low clip, I'd recommend we find a way to reintroduce the scrollbar to help users a) see the onboarding card and opt in and b) because not having a scrollbar can be frustrating. As such, this feels like a P1/P2 with me leaning towards P1.

Comment 4

[Jonathan Epstein]

(In reply to wrocklin from comment #3)

Hey @[e-mail] To answer your question, can you provide more context on this part of your comment: "Given that sidebar will load at its default size when the onboarding card loads"? By "default size" do you mean whatever size the user has their browser set at?

By default size here, I mean the original 320px, in which case, the card is not cut-off, unless someone who is opted out resizes the sidebar.

Comment 5

[wrocklin]

@[e-mail] Think I understand now. Sounds like you're saying because the onboarding card loads by default at 320 where it's not cut off, therefore, do we add a horizontal scroll bar once the user shrinks it down? If that's the case, feels like a solid P2/P3 to me. Since the user has done this and probably knows how to undo it if they want to read it, I'll mark as a P3.

Comment 6

[Rares Doghi, Desktop QA]

After opting in, the other cards will resize and adjust the text accordingly thus creating a Vertical scrollbar, I dont think we should have a horizontal one.
Either the image should resize as well, maybe zoom out a bit when its resized, or the text should just go on the next row creating a vertical scrollbar.

In other cases like the Unanalyzed card there is a mini horizontal scrollbar and it does not look ok, I already logged an issue for that one, the horizontal scrollbar looks out of place underneath the Fakespot by Mozilla link, maybe if the Horizontal scroll bar would be displayed at the bottom of the shopping sidebar it would look a bit better but as of now its in the middle of it.

Comment 7

[Rares Doghi, Desktop QA]

Please also note that if a user opts in to Review Checker, resizes the sidebar and then turns it off from settings, the second time he opens the sidebar it will be resized and he will see the onboarding card once again... I will attach a screen recording of this behavior.

Comment 8

[Rares Doghi, Desktop QA]

Attachment: 2023-11-23_10h41_50.mp4

Comment 9

[kpatenio]

Since this concerns the onboarding card, I'm going to move this over to OMC. If that's incorrect, please revert the change.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit BugBot documentation.

Comment 11

[Punam Dahiya [:pdahiya]]

(In reply to Rares Doghi, Desktop QA from comment #1)

I wasnt sure if I should leave 120 affected or disabled since this is a new feature related to the Review Checker sidebar. The ability to resize the shopping sidebar has been implemented with Bug 1858462.

NI QA to help clarify the issue is replicable only in Fx121+ and fallout of fix of Bug 1858462. Please provide steps to replicate if Fx120 is affected with the issue reported in the bug Thanks!

Comment 12

[Punam Dahiya [:pdahiya]]

Here are findings, fix of Bug 1858462 changed sidebar width from default 320px to 293.367px (em value in styles) and added capability to make sidebar resizable adding need to make opt-in onboarding container to be scrollable.

https://phabricator.services.mozilla.com/D193095#inline-1071777

Comment 13

[Punam Dahiya [:pdahiya]]

Attachment: Shopping Sidebar in Fx120.png

Comment 14

[Punam Dahiya [:pdahiya]]

Attachment: Shopping-Sidebar in Fx121+.png

Comment 15

[Punam Dahiya [:pdahiya]]

NI Niklas to help clarify if sidebar opening at 293px instead of 320px on MacOS is expected https://phabricator.services.mozilla.com/D193095#inline-1071777

Not sure why we went with em values for sidebar widths. Can we consider increasing em width or using px values to resolve sidebar opening at atleast 320px on all platforms
Thanks!

Comment 16

[Niklas Baumgardner [:niklas]]

The sidebar does open at 320px by default on Windows but not mac (whoops). Maybe we should use 320px instead of 26.67em so it is consistent across platforms?

Comment 17

[Rares Doghi, Desktop QA]

Hi, This issue was implemented in 121 only, and its allowing users to resize the shopping sidebar, I marked it as affected in 120 in case of an uplift, I wasn't sure what the best approach was. Should I mark it as disabled for 120 since it was only planned for 121 ?

Comment 18

[Punam Dahiya [:pdahiya]]

Thanks @rdoghi for confirming, yes resize shopping sidebar got implemented in Fx121 with Bug 1858462 and was not uplifted, So marking it disabled or unaffected for Fx120 should work.

Comment 19

[Punam Dahiya [:pdahiya]]

(In reply to Niklas Baumgardner [:niklas] from comment #16)

The sidebar does open at 320px by default on Windows but not mac (whoops). Maybe we should use 320px instead of 26.67em so it is consistent across platforms?

+1, I will open a new bug to update default width (which should be uplifted to Fx121) and keep this bug open to track resize of shopping onboarding container. Thanks!

Comment 20

[Punam Dahiya [:pdahiya]]

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1867336, Changing priority to P3 as per #comment 5. Will be looking at handling survey container resize in Bug 1866501 , fix of which should help with opt-in container

Comment 21

[Rares Doghi, Desktop QA]

Updating the 120 flag.

Comment 22

[Punam Dahiya [:pdahiya]]

Issue resolved with patch addressing fix of Bug 1866501

Comment 23

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 122.0a1 (2023-12-07).

Comment 24

[Rares Doghi, Desktop QA]

Updating the Main Status flag.