1867336 - Update Shopping Sidebar default width to use pixel value

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to update shopping sidebar default width to 320px instead of 26.67em

See https://bugzilla.mozilla.org/show_bug.cgi?id=1865351#c19

Comment 1

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:
Fix of Bug 1858462 changed default width of shopping sidebar in em causing onboarding opt-in container and survey to cut off in MacOS in Fx121+

Comment 2

[Negin Sauermann]

Attachment: Bug 1867336 - Update Shopping Sidebar default width to use pixel value

Comment 3

[Iulian Moraru]

Because the bot didn't comment when the patch landed on autoland I will leave this message with the revision from autoland:
https://hg.mozilla.org/integration/autoland/rev/7e08f5f9cbb4e38b3579328b49609d065203415a

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7e08f5f9cbb4

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nsauermann, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Negin Sauermann]

Comment on attachment 9366139 [details]
Bug 1867336 - Update Shopping Sidebar default width to use pixel value

Beta/Release Uplift Approval Request

• User impact if declined: Shopping sidebar opt-in card will be truncated on macOS, see comment for issue
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - In about:config ensure:
  browser.shopping.experience2023.active is set to true browser.shopping.experience2023.enabled is set to true
  browser.shopping.experience2023.optedIn is set to 0

• Route to amazon.com
• Notice the opt-in shopping sidebar is not truncated on macOS (and all OS)

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): A small change to the styling to use a static width for the sidebar instead of a relative one to ensure consistency across OSs.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9366139 [details]
Bug 1867336 - Update Shopping Sidebar default width to use pixel value

Approved for 121.0b6.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5df38003afc9

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out from 121.0b6 as requested by jhirsch.
Backout link: https://hg.mozilla.org/releases/mozilla-beta/rev/8e00ed90450f29ee0286348a831fc0980397f8e7

Comment 10

[kpatenio]

As a result of backing out https://bugzilla.mozilla.org/show_bug.cgi?id=1858762, --shopping-sidebar-width is removed (sorry). Setting to width should suffice.

Comment 11

[Cosmin Sabou [:CosminS]]

Backed out also from 122 as requested by jhirsch.
Backout link: https://hg.mozilla.org/integration/autoland/rev/9d2831e8fb6f07970d725c286f8b156512ba6d5a
Setting wontfix as Jared mentioned on matrix.

Comment 12

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/9d2831e8fb6f

Comment 13

[Negin Sauermann]

Comment on attachment 9366139 [details]
Bug 1867336 - Update Shopping Sidebar default width to use pixel value

(Sorry for the double beta uplift req, unsure if it needs another one since the original got backed out! see comment for context)

Beta/Release Uplift Approval Request

• User impact if declined: Shopping sidebar opt-in card will be truncated on macOS, see comment for issue
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: In about:config ensure:
  browser.shopping.experience2023.active is set to true browser.shopping.experience2023.enabled is set to true
  browser.shopping.experience2023.optedIn is set to 0

• Route to amazon.com
• Notice the opt-in shopping sidebar is not truncated on macOS (and all OS)

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): A small change to the styling to use a static width for the sidebar instead of a relative one to ensure consistency across OSs.
• String changes made/needed:
• Is Android affected?: No

Comment 14

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Sorry, bit of a misunderstanding here--I had asked for the animation bug to be wontfixed, but didn't mention this related bug

Comment 15

[Negin Sauermann]

(In reply to Jared Hirsch [:jhirsch] (he/him) (Needinfo please) from comment #14)

Sorry, bit of a misunderstanding here--I had asked for the animation bug to be wontfixed, but didn't mention this related bug

No worries! Going to re-open this bug and set it back to affected for Fx121 and 122.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/371b0bc9d41a
Update Shopping Sidebar default width to use pixel value r=desktop-theme-reviewers,niklas,dao

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9366139 [details]
Bug 1867336 - Update Shopping Sidebar default width to use pixel value

Re-approved for 121.0b7!

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2f43b5da0fd4

Comment 19

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/371b0bc9d41a

Comment 20

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta and Nightly builds 122.0a1 (2023-12-05).