Go to any youtube video Click on the Gears button within the video AR: the two sliders are cut-off ER: Not so Regression: Bug 221154 - Tweak a few crashtest assertion counts. r=dholbert The padding changes causes some sizes in the child to not exactly be nscoord_MAX when overflowing, but a slightly smaller value, not hitting the width == nscoord_MAX || height == nscoord_MAX condition in FinishStoreOverflow(). The other one is similar, where an nscoord_MAX value gets to bidi reordering, where it didn't before. It doesn't seem problematic / anything that wouldn't otherwise happen with a regular block with padding. Tweak while at it some of the overflow areas assertions, mostly to make it simpler, but also because I'm not super-positive about the compiler being able to optimize it away entirely on opt builds. Depends on D197978 Differential Revision: https://phabricator.services.mozilla.com/D199241
Bug 1877719 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Go to any youtube video Click on the Gears button within the video AR: the two sliders are cut-off ER: Not so ------------------------------------------------------------------------------------------ Regression: Bug 221154 - Tweak a few crashtest assertion counts. r=dholbert The padding changes causes some sizes in the child to not exactly be nscoord_MAX when overflowing, but a slightly smaller value, not hitting the width == nscoord_MAX || height == nscoord_MAX condition in FinishStoreOverflow(). The other one is similar, where an nscoord_MAX value gets to bidi reordering, where it didn't before. It doesn't seem problematic / anything that wouldn't otherwise happen with a regular block with padding. Tweak while at it some of the overflow areas assertions, mostly to make it simpler, but also because I'm not super-positive about the compiler being able to optimize it away entirely on opt builds. Depends on D197978 Differential Revision: https://phabricator.services.mozilla.com/D199241 --------------------------------------------- repros at both 1.5 and 1 DPI