221154 - table cells do not support 'overflow' correctly

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Table cells do not support 'overflow' correctly.  They don't support 'auto' and
'scroll' at all, and their support for 'hidden' is incorrect (thanks to the hack
that fixet bug 221140).

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: testcase

Comment 2

[Anne (:annevk)]

Isn't this just bug 39683, since in CSS21 'height' and 'width' on a 'table-cell'
are actually 'min-width' and 'min-height':

<http://www.w3.org/TR/CSS21/tables.html#height-layout>:
> In CSS 2.1, the height of a cell box is the maximum of the table cell's
> 'height' property and the minimum height required by the content (MIN). A 
> value of 'auto' for 'height' implies a that the value MIN will be used for
> layout. CSS 2.1 does not define what percentage values of 'height' refer to
> when specified for table cells.

<http://www.w3.org/TR/CSS21/tables.html#auto-table-layout>

Comment 3

[Bernd]

Anne, no this bug is about a design flaw in table cell frame construction where
it does not wrap the frame in to a scollable frame like the row group frame does
(http://lxr.mozilla.org/seamonkey/source/layout/html/style/src/nsCSSFrameConstructor.cpp#2601)

Comment 5

[Michael Lippert]

Attachment: testcase of overflow:scroll on child element of td element

Comment 6

[Michael Lippert]

I'm pretty sure this is related, so I didn't want to open another bug.
I've attached another testcase file named testcase2.html which is a barely edited file of where I encountered the issue.

Note that the pre element does not fully display all of its contents, it seems to end after line 2523 of the testcase2.html file, and is followed by a significant amount of blank space before the end of the document is reached.

The pre element is styled by overflow: scroll associated by the class="log". This element is in a td element which is why I think it is related to this bug.

Comment 7

[Dusan Maliarik]

Okay, this really is a non sense. This bug exists since 2003. How many releases did we have since then? How am I supposed to do vertical layout? Assigned to nobody?

Great care Mozilla, it works perfectly with WebKit. Hope there will be Chrome Frame for Firefox soon, and popular.

Comment 8

[Dusan Maliarik]

Attachment: another test case

Comment 10

[Peter Krautzberger]

(In reply to Dusan Maliarik from comment #7)
> Okay, this really is a non sense. This bug exists since 2003. 


I just filed what turned out to be a duplicate so I'd second Dusan's sentiment (another 7 years later). All other browsers (IE9+) handle this consistently.

Comment 11

[Dave]

boooooooo

Comment 16

[Gérard Talbot]

Additional tests:
http://www.gtalbot.org/BrowserBugsSection/css22testsuite/overflow-auto-applies-to-table-cell-001.html
http://www.gtalbot.org/BrowserBugsSection/css22testsuite/overflow-auto-applies-to-table-cell-003.html

Comment 18

[Karl Dubost💡 :karlcow]

We do not have any live site examples. The only issue we had has been fixed by the website itself.

Comment 19

[BugBot [:suhaib / :marco]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 20

[BugBot [:suhaib / :marco]]

The severity field for this bug is relatively low, S3. However, the bug has 7 duplicates and 10 votes.
:dholbert, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 21

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Comment 23

[Gérard Talbot]

Firefox stable version and Firefox 123 nightly fail these 3 tests:

https://wpt.fyi/results/css/css-backgrounds?label=experimental&label=master&aligned&q=table-cell-background-local

Comment 24

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 221154 - Make overflow work on table cells. r=dholbert

Comment 26

[Emilio Cobos Álvarez [:emilio]]

https://treeherder.mozilla.org/jobs?repo=try&revision=de4c13018b5b65498c9a6d9ea1379e253402ec07 (ftr)

Comment 27

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 221154 - Make ::-moz-table-content inherit padding from the table cell. r=dholbert

This doesn't change behavior but it's a prerequisite to supporting a
scrollframe properly (since we want the padding inside the scrolled
area).

This follows a bit what nsFieldSetFrame does.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/274f73457318
Make ::-moz-table-content inherit padding from the table cell. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/166b593890ef
Make overflow work on table cells. r=dholbert

Comment 29

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44096 for changes under testing/web-platform/tests

Comment 30

[Narcis Beleuzu [:NarcisB]]

Backed out for causing crashtests

Backout link: https://hg.mozilla.org/integration/autoland/rev/54d08cb9878b44b761f5729a21f05d6a95aedfc1
Log link: https://treeherder.mozilla.org/logviewer?job_id=443956592&repo=autoland&lineNumber=17790

Comment 31

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 32

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 221154 - Tweak a few crashtest assertion counts. r=dholbert

The padding changes causes some sizes in the child to not exactly be
nscoord_MAX when overflowing, but a slightly smaller value, not hitting
the width == nscoord_MAX || height == nscoord_MAX condition in
FinishStoreOverflow().

The other one is similar, where an nscoord_MAX value gets to bidi
reordering, where it didn't before. It doesn't seem problematic /
anything that wouldn't otherwise happen with a regular block with
padding.

Depends on D197978

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e194aafccb17
Make ::-moz-table-content inherit padding from the table cell. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/271097ebb915
Make overflow work on table cells. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/2211ddf306e0
Tweak a few crashtest assertion counts. r=dholbert

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a73c4546b986
Fix non-unified build.

Comment 35

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e194aafccb17
https://hg.mozilla.org/mozilla-central/rev/271097ebb915
https://hg.mozilla.org/mozilla-central/rev/2211ddf306e0
https://hg.mozilla.org/mozilla-central/rev/a73c4546b986

Comment 36

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot