1877719 - Sliders (binary sliders? Switches?) on youtube in-video settings are cut-off

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Mayank Bansal]

Go to any youtube video
Click on the Gears button within the video

AR: the two sliders are cut-off
ER: Not so

Regression:
Bug 221154 - Tweak a few crashtest assertion counts. r=dholbert

The padding changes causes some sizes in the child to not exactly be
nscoord_MAX when overflowing, but a slightly smaller value, not hitting
the width == nscoord_MAX || height == nscoord_MAX condition in
FinishStoreOverflow().

The other one is similar, where an nscoord_MAX value gets to bidi
reordering, where it didn't before. It doesn't seem problematic /
anything that wouldn't otherwise happen with a regular block with
padding.

Tweak while at it some of the overflow areas assertions, mostly
to make it simpler, but also because I'm not super-positive about
the compiler being able to optimize it away entirely on opt builds.

Depends on D197978

Differential Revision: https://phabricator.services.mozilla.com/D199241

---

repros at both 1.5 and 1 DPI

Comment 1

[Mayank Bansal]

This should be a high priority bug considering its on youtube, IMHO. I am surprised that nobody reported this regression!

Comment 2

[Mayank Bansal]

Attachment: about:support

Comment 3

[Mayank Bansal]

Attachment: bad2.png

Comment 4

[Mayank Bansal]

Attachment: bad.png

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 221154

Comment 6

[Emilio Cobos Álvarez [:emilio]]

[Tracking Requested - why for this release]: We should not ship this youtube regression.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Reduced test-case.

Comment 8

[BugBot [:suhaib / :marco]]

The bug is marked as tracked for firefox124 (nightly). We have limited time to fix this, the soft freeze is in 14 days. However, the bug still isn't assigned.

:fgriffith, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 9

[Frederik Braun [:freddy]]

Soft code freeze is approaching. Do you think you will be able to make a patch soon, Emilio?

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1877719 - Turn off overflow support on table cells in beta for now. r=#layout

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e397ddbbb2f4
Turn off overflow support on table cells in beta for now. r=layout-reviewers,tnikkel

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e397ddbbb2f4

Comment 13

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 221154

Comment 14

[Emilio Cobos Álvarez [:emilio]]

Removing my needinfo, this will be fixed by the work in bug 1883699.

Comment 15

[Daniel Holbert [:dholbert]]

--> status-firefox125 is disabled now that 125 is beta, per the patch that landed in comment 11 (which put the behavior in question behind a Nightly-channel-only guard)

(This applies to later versions as well, once they hit beta, until we revert the patch that landed in comment 11 [after bug 1883699 is fixed] to let this work ride the trains.)

Comment 16

[Daniel Holbert [:dholbert]]

(For the same reason, there's no need to track this for the 124 release anymore, or any particular release, given the nightly-channel-only guard. Resetting the tracking flag.)

Comment 17

[Daniel Holbert [:dholbert]]

Reducing severity to S3 given that this is a cosmetic issue (the slider still functions, it just looks a little weird) and we've got this behavior behind a pref to prevent it from shipping to any releases beyond Nightly (which we won't let happen until we've addressed the blockers to bug 1904159, including this one, via bug 1883699 and potentially other improvements).

Comment 20

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1877719 - Turn off scrollable table cells for now. r=dholbert,#layout

I hope to get to bug 1883699 soon, but I'm clearly not being as fast as
I hoped, so let's turn this off for now until that's fixed.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/856110cdb870
Turn off scrollable table cells for now. r=dholbert

Comment 22

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/856110cdb870