Bugzilla

(In reply to Alex Cornestean from comment #5)
> I was checking out the try build and even though everything appears to be in order with the implementation of the mechanism to show the full list of domains in the optional permissions request dialog (i.e. the “Show all sites”/”Show fewer sites” buttons appear on the optional permissions dialog and work as expected), I would like to point out that when the “Dark” theme is enabled, the same issue as in Bug 1947741 occurs.
> 
> I was not able to find whether Bug 1947741 also addressed the issue for the optional permissions dialog, but I wanted to give a heads up in case it didn’t, before the patches are merged to mozilla central post review.

Hi Alex,
That is likely due to my try push from comment 4 to be older than the for for Bug 1947741 landing in mozilla-central (my try push seems to be from 17 days ago, while the fix for Bug 1947741 landed 14 days ago).

Now that the attached patch has been reviewed and signed off from an Android peer, I'm going to rebase the 2 patches today and I will post here a new push to try, the new push to try should then also include Bug 1947741 fix for the dark mode.

(In reply to Alex Cornestean from comment #5)
> I was checking out the try build and even though everything appears to be in order with the implementation of the mechanism to show the full list of domains in the optional permissions request dialog (i.e. the “Show all sites”/”Show fewer sites” buttons appear on the optional permissions dialog and work as expected), I would like to point out that when the “Dark” theme is enabled, the same issue as in Bug 1947741 occurs.
> 
> I was not able to find whether Bug 1947741 also addressed the issue for the optional permissions dialog, but I wanted to give a heads up in case it didn’t, before the patches are merged to mozilla central post review.

Hi Alex,
That is likely due to my try push from comment 4 to be older than the patch for Bug 1947741 landing in mozilla-central (my try push seems to be from 17 days ago, while the fix for Bug 1947741 landed 14 days ago).

Now that the attached patch has been reviewed and signed off from an Android peer, I'm going to rebase the 2 patches today and I will post here a new push to try, the new push to try should then also include Bug 1947741 fix for the dark mode.