1935680 - Show the full list of domains the extensions is requesting through optional permissions request dialog

Status: VERIFIED FIXED

(Firefox for Android :: WebExtensions, enhancement, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As a followup to Bug 1911999, which is introducing the full domains list for the dialog shown for the permissions granted at install time, we should show the full domains list also in the dialog opened when the extensions is requesting optional permissions through the permissions WebExtensions API (See https://phabricator.services.mozilla.com/D223018#7985396 for some more details about the changes that may be likely part of this followup).

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1935680 - Show full list of domains in Fenix optional permissions request dialog.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Fenix-optional-permission-dialog-before-and-after-Bug1935680.png

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1935680 - Updated android-components changelog.

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

try push (using firefox-android preset): https://treeherder.mozilla.org/jobs?repo=try&revision=83f64a5ac639b1d56512c75895ef5a8078a5383a

Comment 5

[Alex Cornestean]

I was checking out the try build and even though everything appears to be in order with the implementation of the mechanism to show the full list of domains in the optional permissions request dialog (i.e. the “Show all sites”/”Show fewer sites” buttons appear on the optional permissions dialog and work as expected), I would like to point out that when the “Dark” theme is enabled, the same issue as in Bug 1947741 occurs.

I was not able to find whether Bug 1947741 also addressed the issue for the optional permissions dialog, but I wanted to give a heads up in case it didn’t, before the patches are merged to mozilla central post review.

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Alex Cornestean from comment #5)

I was checking out the try build and even though everything appears to be in order with the implementation of the mechanism to show the full list of domains in the optional permissions request dialog (i.e. the “Show all sites”/”Show fewer sites” buttons appear on the optional permissions dialog and work as expected), I would like to point out that when the “Dark” theme is enabled, the same issue as in Bug 1947741 occurs.

I was not able to find whether Bug 1947741 also addressed the issue for the optional permissions dialog, but I wanted to give a heads up in case it didn’t, before the patches are merged to mozilla central post review.

Hi Alex,
That is likely due to my try push from comment 4 to be older than the patch for Bug 1947741 landing in mozilla-central (my try push seems to be from 17 days ago, while the fix for Bug 1947741 landed 14 days ago).

Now that the attached patch has been reviewed and signed off from an Android peer, I'm going to rebase the 2 patches today and I will post here a new push to try, the new push to try should then also include Bug 1947741 fix for the dark mode.

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

New push to try (using firefox-android preset and rebased on top of Bug 1947741 fix for the dark mode): https://treeherder.mozilla.org/jobs?repo=try&revision=ba9650fac31c212fefac9b4ffbb2a6e6d81f77ad

Comment 8

[Alex Cornestean]

(In reply to Luca Greco [:rpl] [:luca] [:lgreco] from comment #7)

New push to try (using firefox-android preset and rebased on top of Bug 1947741 fix for the dark mode): https://treeherder.mozilla.org/jobs?repo=try&revision=ba9650fac31c212fefac9b4ffbb2a6e6d81f77ad

Thank you for the info, Luca ! Just tried the new push to try. It includes the fix for dark mode and everything seems to work as expected overall.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a95219583e33
Show full list of domains in Fenix optional permissions request dialog. r=android-reviewers,twhite,willdurand

Comment 10

[amarc]

https://hg.mozilla.org/mozilla-central/rev/a95219583e33

Comment 11

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly for Android (138.0a1-20250323000437) on an Oppo Reno 6 running Android 13 using an extension allowing the triggering of the optional permissions request dialog for 8 domains.

The optional permissions request dialog will initially show a list of 5 domains of the 8 required and a “Show all sites” button at the bottom.
Tapping the “Show all sites” button will expand the dialog and the list to show all 8 domains. The “Show all sites” turns into “Show fewer sites” and moves at the top of the list.
Tapping the “Show fewer sites” button will collapse both the dialog and domains list to their original size and number of shown domains.

Considering the above, the issue is fixed. See the attached screenshots for more details.

Comment 12

[Alex Cornestean]

Attachment: 6440c4b4-9740-47d4-86b6-e6461196269e.JPEG

Comment 13

[Alex Cornestean]

Attachment: d3f1d4c1-aa93-462b-bbe9-846db39bd749.JPEG