I didn't include removing SEAMONKEY_VERSION yet so I converted it to just reflect MOZ_APP_VERSION for now because MOZ_APP_VERSION is now automatically handled by the build system and can't be simply changed by a directive in moz.configure without a when= conditional attached so SEAMONKEY_VERSION to MOZ_APP_VERSION would not work going forward and separate handling seems redundant and as indicated SEAMONKEY_VERSION needs to just go away. While I am doing these sort of roll ups I don't want them to be impenetrable to analysis or splitting even more granularly. As for the updater it is by default on in the "platform" so it is not required to have it explicitly. Thunderbird moved that over from confvars.sh but it needs to be in its --option format rather than the build define to be accepted by moz.configure. I'll update the patches to remove enabling the already enabled updater and the references for related bugs in part 1 and add a part 4 for removing SEAMONKEY_VERSION cause its scope is a bit wider than just suite/moz.configure. Does that sound good?
Bug 1952288 Comment 6 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Bug 1951143 while just the final bits for Thunderbird included a bunch of changes not done when Thunderbird did them in June 2024. They also busted SeaMonkey building which is what started this. I didn't include removing SEAMONKEY_VERSION yet so I converted it to just reflect MOZ_APP_VERSION for now because MOZ_APP_VERSION is now automatically handled by the build system and can't be simply changed by a directive in moz.configure without a when= conditional attached so SEAMONKEY_VERSION to MOZ_APP_VERSION would not work going forward and separate handling seems redundant and as indicated SEAMONKEY_VERSION needs to just go away. While I am doing these sort of roll ups I don't want them to be impenetrable to analysis or splitting even more granularly. As for the updater it is by default on in the "platform" so it is not required to have it explicitly. Thunderbird moved that over from confvars.sh but it needs to be in its --option format rather than the build define to be accepted by moz.configure. I'll update the patches to remove enabling the already enabled updater and the references for related bugs in part 1 and add a part 4 for removing SEAMONKEY_VERSION cause its scope is a bit wider than just suite/moz.configure. Does that sound good?
Bug 1951143 while just the final bits for Thunderbird included a bunch of changes to suite that was not done when Thunderbird did them for Thunderbird in June 2024. They also busted SeaMonkey building which is what started this. I didn't include removing SEAMONKEY_VERSION yet so I converted it to just reflect MOZ_APP_VERSION for now because MOZ_APP_VERSION is now automatically handled by the build system and can't be simply changed by a directive in moz.configure without a when= conditional attached so SEAMONKEY_VERSION to MOZ_APP_VERSION would not work going forward and separate handling seems redundant and as indicated SEAMONKEY_VERSION needs to just go away. While I am doing these sort of roll ups I don't want them to be impenetrable to analysis or splitting even more granularly. As for the updater it is by default on in the "platform" so it is not required to have it explicitly. Thunderbird moved that over from confvars.sh but it needs to be in its --option format rather than the build define to be accepted by moz.configure. I'll update the patches to remove enabling the already enabled updater and the references for related bugs in part 1 and add a part 4 for removing SEAMONKEY_VERSION cause its scope is a bit wider than just suite/moz.configure. Does that sound good?