1951143 - Move configuration variables from confvars.sh to moz.configure

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Corey Bryant]

We need to move configuration variables that are not flagged as confvar from confvars.sh to moz.configure. This matches the recent configuration changes in mozilla-central.

sergesanspaille submitted the following patch:
https://phabricator.services.mozilla.com/D239871

but it resulted in build bustage so was not checked in:
https://bugzilla.mozilla.org/show_bug.cgi?id=1950637#c19

That patch was submitted for the following bug but a new bug was needed to track the comm-central changes:
https://bugzilla.mozilla.org/show_bug.cgi?id=1950637

Comment 1

[Corey Bryant]

https://treeherder.mozilla.org/logviewer?job_id=496986566&repo=try-comm-central&lineNumber=958

[task 2025-02-28T09:24:00.450Z] 09:24:00    ERROR -  Traceback (most recent call last):
[task 2025-02-28T09:24:00.451Z] 09:24:00     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 345, in <module>
[task 2025-02-28T09:24:00.451Z] 09:24:00     INFO -      sys.exit(main(sys.argv))
[task 2025-02-28T09:24:00.451Z] 09:24:00     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 140, in main
[task 2025-02-28T09:24:00.451Z] 09:24:00     INFO -      sandbox.run()
[task 2025-02-28T09:24:00.451Z] 09:24:00     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 525, in run
[task 2025-02-28T09:24:00.451Z] 09:24:00     INFO -      self._value_for(option)
[task 2025-02-28T09:24:00.451Z] 09:24:00     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 630, in _value_for
[task 2025-02-28T09:24:00.452Z] 09:24:00     INFO -      return self._value_for_option(obj)
[task 2025-02-28T09:24:00.452Z] 09:24:00     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/util.py", line 917, in method_call
[task 2025-02-28T09:24:00.452Z] 09:24:00     INFO -      cache[args] = self.func(instance, *args)
[task 2025-02-28T09:24:00.452Z] 09:24:00     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 665, in _value_for_option
[task 2025-02-28T09:24:00.452Z] 09:24:00     INFO -      value, option_string = self._helper.handle(option)
[task 2025-02-28T09:24:00.452Z] 09:24:00     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/options.py", line 616, in handle
[task 2025-02-28T09:24:00.452Z] 09:24:00     INFO -      extra_ret = option.get_value(extra_arg, extra_origin)
[task 2025-02-28T09:24:00.453Z] 09:24:00     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/configure/options.py", line 443, in get_value
[task 2025-02-28T09:24:00.453Z] 09:24:00     INFO -      raise InvalidOptionError(
[task 2025-02-28T09:24:00.453Z] 09:24:00     INFO -  mozbuild.configure.options.InvalidOptionError: MOZ_APP_PROFILE=thunderbird can not be set by implied. Values are accepted from: confvars

Comment 2

[[:sergesanspaille]]

Attachment: Bug 1951143 - Turn MOZ_APP_PROFILE into a project_flag r=corey

Comment 3

[[:sergesanspaille]]

Attachment: Bug 1951143 - Move configuration variables from confvars.sh to moz.configure r=corey

This matches the recent configuration changes in mozilla-central: only
variable flagged as confvar should be set in confvars.sh

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e38633053359
Turn MOZ_APP_PROFILE into a project_flag r=coreycb

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e38633053359

Comment 6

[Takanori MATSUURA]

Reopened for the unpublished changeset.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b435ffb3aec9
Move configuration variables from confvars.sh to moz.configure r=coreycb

Comment 8

[Corey Bryant]

Comment on attachment 9469418 [details]
Bug 1951143 - Turn MOZ_APP_PROFILE into a project_flag r=corey

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Thunderbird needs this patch for successful builds.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): With both patches from this bug, comm-central builds successfully:
  https://treeherder.mozilla.org/jobs?repo=comm-central&revision=b435ffb3aec9f5135f91dee274bb11a8f1fb5f9c
  vs comm-beta:
  https://treeherder.mozilla.org/jobs?repo=comm-beta&revision=e86266d4b1e11752e05e898828e7eb983e18e666
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/158af1a5f1c3

Comment 10

[Corey Bryant]

Comment on attachment 9469420 [details]
Bug 1951143 - Move configuration variables from confvars.sh to moz.configure r=corey

[User impact if declined]
Thunderbird needs the mozilla-beta and comm-beta patches for successful builds.

[Is this code covered by automated tests?]
No

[Has the fix been verified in Daily? (or Beta for an ESR uplift?)]
Yes

[Needs manual test from QA?]
No

[List of other uplifts needed]
The mozilla-beta uplift from this bug is also needed.

[Risk to taking this patch]
Low. With both patches from this bug, comm-central builds successfully:
https://treeherder.mozilla.org/jobs?repo=comm-central&revision=b435ffb3aec9f5135f91dee274bb11a8f1fb5f9c

[Why is the change risky/not risky? (and alternatives if risky)]
Fixes are working on comm-central

[String changes made/needed]
None

Comment 11

[Corey Bryant]

Comment on attachment 9469420 [details]
Bug 1951143 - Move configuration variables from confvars.sh to moz.configure r=corey

[Triage Comment]
Approved for beta