1952288 - Fix and revamp suite build configuration and options

Status: ASSIGNED

(SeaMonkey :: Build Config, defect)

Description

[Matt A. Tobin [:nsITobin]]

In Bug 1951143 on central the Thunderbird folks rolled up a number of confvar related changes that they rolled out last summer (June 2024) to SeaMonkey. There were a couple of issues with the port of a few things as-is and really moz.configure and surrounding suite build configuration could use a serious once over and clean up.

Comment 1

[Matt A. Tobin [:nsITobin]]

Attachment: BUG-1952288-p1-1651143-fixup.patch

Comment 2

[Matt A. Tobin [:nsITobin]]

Attachment: BUG-1952288-p2-moz-configure-revamp.patch

Comment 3

[Matt A. Tobin [:nsITobin]]

Attachment: BUG-1952288-p3-moz-configure-additional-defaults.patch

Comment 4

[Matt A. Tobin [:nsITobin]]

Comment on attachment 9470316 [details] [diff] [review]
BUG-1952288-p1-1651143-fixup.patch

Part 1 (The fixup)

Comment 5

[Ian Neal]

Comment on attachment 9470316 [details] [diff] [review]
BUG-1952288-p1-1651143-fixup.patch

I think the bug number you are fixing up from is 1951143 not 1651143
There are other bugs that need porting for SEAMONKEY_VERSION as part of this fixup e.g.:

• Bug 1507948 - Port bug 1502457 and remove THUNDERBIRD_VERSION and use MOZ_APP_VERSION in python configure.
• Bug 1816266 - Remove THUNDERBIRD_VERSION configure variables. (4th patch for that bug number)

Looking at:

• Bug 1747855 - Move --disable-updater to python configure.
• Bug 1747981 - Port bug 1747855: Move --disable-updater to python configure.

Is imply_option("--enable-updater", True) needed?

f+ for the moment as I'd like to review the next version

Comment 6

[Matt A. Tobin [:nsITobin]]

Bug 1951143 while just the final bits for Thunderbird included a bunch of changes to suite that was not done when Thunderbird did them for Thunderbird in June 2024. They also busted SeaMonkey building which is what started this.

I didn't include removing SEAMONKEY_VERSION yet so I converted it to just reflect MOZ_APP_VERSION for now because MOZ_APP_VERSION is now automatically handled by the build system and can't be simply changed by a directive in moz.configure without a when= conditional attached so SEAMONKEY_VERSION to MOZ_APP_VERSION would not work going forward and separate handling seems redundant and as indicated SEAMONKEY_VERSION needs to just go away.

While I am doing these sort of roll ups I don't want them to be impenetrable to analysis or splitting even more granularly.

As for the updater it is by default on in the "platform" so it is not required to have it explicitly. Thunderbird moved that over from confvars.sh but it needs to be in its --option format rather than the build define to be accepted by moz.configure.

I'll update the patches to remove enabling the already enabled updater and the references for related bugs in part 1 and add a part 4 for removing SEAMONKEY_VERSION cause its scope is a bit wider than just suite/moz.configure.

Does that sound good?

Comment 7

[Matt A. Tobin [:nsITobin]]

I have removed the redundant --enable-updater option and created a part 4 which basically does the applicable lot from 1816266 including SEAMONKEY_VERSION which was previously tackled in Bug 1817633.

I will update the patches in the morning. I don't want to create a bunch of bugspam from late-evening mistakes.