In splitting these bugs up the way I did, I was trying to keep them scoped small, partly for easier review, but after working on bug 1995574 I see that it will make review harder in a different way: by spreading out closely related internal Suggest changes over two different bugs. So I'm thinking the right way to split these up is internal Suggest changes vs. external changes. I'll go ahead and take this bug while I work it out because there will likely be some overlap between the two bugs as they are currently written, and we'll need to morph them and maybe file new ones.
Bug 1995577 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
In splitting these bugs up the way I did, I was trying to keep them scoped small, partly for easier review, but after working on bug 1995574 I see that it will make review harder in a different way: by spreading out closely related internal Suggest changes over two different bugs. Not just review, but it's making it harder as the patch author. So I'm thinking the right way to split these up is internal Suggest changes vs. external changes. I'll go ahead and take this bug while I work it out because there will likely be some overlap between the two bugs as they are currently written, and we'll need to morph them and maybe file new ones.