1995577 - Update the settings UI for the new `browser.urlbar.suggest.quicksuggest.all` pref

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Mark Banner (:standard8)]

Continuing on from bug 1995574, we want to complete the transition to the new all preference:

• Add a QuickSuggest migration to set the all preference to false if the nonsponsored preference is false only on the user branch.
• Update SuggestProviders so that they no longer gate themselves on nonsponsored.
• Update the settings UI, to use the new all preference, and indent the two sub-options.
• Update the settings UI to disable the two sub-options if the all preference is disabled.
• Update enterprise policies & telemetry.
• Remove any remaining nonsponsored pref references
• Update tests.

Comment 1

[Drew Willcoxon :adw]

In splitting these bugs up the way I did, I was trying to keep them scoped small, partly for easier review, but after working on bug 1995574 I see that it will make review harder in a different way: by spreading out closely related internal Suggest changes over two different bugs. Not just review, but it's making it harder as the patch author. So I'm thinking the right way to split these up is internal Suggest changes vs. external changes. I'll go ahead and take this bug while I work it out because there will likely be some overlap between the two bugs as they are currently written, and we'll need to morph them and maybe file new ones.

Comment 2

[Drew Willcoxon :adw]

Let's morph this to be about updating the settings UI:

(In reply to Mark Banner (:standard8) from comment #0)

• Update the settings UI, to use the new all preference, and indent the two sub-options.
• Update the settings UI to disable the two sub-options if the all preference is disabled.

I'm covering the other important points in bug 1995574, and I'll file bugs for the remaining uses of nonsponsored.

I'll unassign myself from this, so Mark, feel free to take it and any of the other bugs if you'd like.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1995577 - Update the settings UI for the new browser.urlbar.suggest.quicksuggest.all pref. r?adw!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/aeb9e95ec410
https://hg.mozilla.org/integration/autoland/rev/a0cb01f17057
Update the settings UI for the new browser.urlbar.suggest.quicksuggest.all pref. r=adw,fluent-reviewers,mstriemer,bolsson

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/a0cb01f17057