1995574 - Replace the `browser.urlbar.suggest.quicksuggest.nonsponsored` pref with `browser.urlbar.suggest.quicksuggest.all` in core Suggest code

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Mark Banner (:standard8)]

As part of the work for the proxy suggest, we want to add a new preference (browser.urlbar.suggest.quicksuggest.all) that will replace the current browser.urlbar.suggest.quicksuggest.nonsponsored preference.

This is because in the settings UI, the current sponsored & improve preferences will be moved to be a level underneath the existing non-sponsored preference, and hence will be controlled/overridden for those.

For this bug, we want to:

• Add the new preference, as a sticky pref (defaulted to true)
• Add it to the default prefs in QuickSuggest
• Update most of the SuggestProviders so that they will gate themselves on the new preference.
• Update tests as appropriate.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1995574 - Part 1: Core Suggest code: Replace the `browser.urlbar.suggest.quicksuggest.nonsponsored` pref with `browser.urlbar.suggest.quicksuggest.all`.

This is part 1 of 5 and integrates the new all pref with core Suggest code
plus AMP and Wikipedia suggestions.

To recap, we're removing the nonsponsored pref and adding a new pref that
controls all Suggest suggestions, which this patch calls all. In order for
nonsponsored suggestions to be shown, all must be true. For sponsored
suggestions to be shown, both all and suggest.quicksuggest.sponsored must be
true.

Depends on D269720

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1995574 - Part 2: Dynamic Rust suggestions: Replace the `browser.urlbar.suggest.quicksuggest.nonsponsored` pref with `browser.urlbar.suggest.quicksuggest.all`.

This integrates the new all pref with dynamic Rust suggestions. I added a way
for them to bypass the all check by setting bypassSuggestAll. That will
allow us to use dynamic suggestions for suggestion types that aren't considered
part of the Suggest brand proper, like important dates, exposure suggestions,
and whatever else we might need.

Depends on D269893

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1995574 - Part 3: Other Suggest features: Replace the `browser.urlbar.suggest.quicksuggest.nonsponsored` pref with `browser.urlbar.suggest.quicksuggest.all`.

This integrates the new all pref with the remaining Suggest features that
aren't handled in parts 1 and 2.

Depends on D269894

Comment 4

[Drew Willcoxon :adw]

Attachment: Bug 1995574 - Part 4: Add a Suggest migration: Replace the `browser.urlbar.suggest.quicksuggest.nonsponsored` pref with `browser.urlbar.suggest.quicksuggest.all`.

This adds a migration that copies the nonsponsored pref to the new all pref.

Depends on D269895

Comment 5

[Drew Willcoxon :adw]

Attachment: Bug 1995574 - Part 5: Update pref telemetry and "disable" telemetry: Replace the `browser.urlbar.suggest.quicksuggest.nonsponsored` pref with `browser.urlbar.suggest.quicksuggest.all`.

This updates pref telemetry and "disable" telemetry for the new all pref and
the removal of the nonsponsored pref.

Depends on D269896

Comment 6

[Drew Willcoxon :adw]

Morphing this bug a little to cover replacement of nonsponsored in core Suggest code (see bug 1995577 comment 1). I will leave some remaining uses of the pref in other places to be handled in bug 1995577 and other bugs to be filed:

browser/app/profile/firefox.js
browser/components/enterprisepolicies/Policies.sys.mjs
browser/components/preferences/
toolkit/components/telemetry/app/TelemetryEnvironment.sys.mjs
toolkit/components/telemetry/docs/data/environment.rst

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/febe4d9096a9
https://hg.mozilla.org/integration/autoland/rev/dfceec4bab74
Part 1: Core Suggest code: Replace the `browser.urlbar.suggest.quicksuggest.nonsponsored` pref with `browser.urlbar.suggest.quicksuggest.all`. r=daisuke,Standard8,urlbar-reviewers
https://github.com/mozilla-firefox/firefox/commit/8007d79861e5
https://hg.mozilla.org/integration/autoland/rev/ff8642d0fcdd
Part 2: Dynamic Rust suggestions: Replace the `browser.urlbar.suggest.quicksuggest.nonsponsored` pref with `browser.urlbar.suggest.quicksuggest.all`. r=daisuke,urlbar-reviewers
https://github.com/mozilla-firefox/firefox/commit/2d40e63c43e8
https://hg.mozilla.org/integration/autoland/rev/ffd775187850
Part 3: Other Suggest features: Replace the `browser.urlbar.suggest.quicksuggest.nonsponsored` pref with `browser.urlbar.suggest.quicksuggest.all`. r=daisuke,Standard8,urlbar-reviewers
https://github.com/mozilla-firefox/firefox/commit/5530250cfc2f
https://hg.mozilla.org/integration/autoland/rev/3855b903071e
Part 4: Add a Suggest migration: Replace the `browser.urlbar.suggest.quicksuggest.nonsponsored` pref with `browser.urlbar.suggest.quicksuggest.all`. r=daisuke,Standard8,urlbar-reviewers
https://github.com/mozilla-firefox/firefox/commit/35865c3f9926
https://hg.mozilla.org/integration/autoland/rev/5c9a511239d4
Part 5: Update pref telemetry and "disable" telemetry: Replace the `browser.urlbar.suggest.quicksuggest.nonsponsored` pref with `browser.urlbar.suggest.quicksuggest.all`. r=daisuke,Standard8,urlbar-reviewers

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/dfceec4bab74
https://hg.mozilla.org/mozilla-central/rev/ff8642d0fcdd
https://hg.mozilla.org/mozilla-central/rev/ffd775187850
https://hg.mozilla.org/mozilla-central/rev/3855b903071e
https://hg.mozilla.org/mozilla-central/rev/5c9a511239d4