1030251 - Add Google logo to search plugin so about:newtab can use it

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Drew Willcoxon :adw]

Attachment: patch

Boriss posted these images in bug 1006203 comment 24 and 25.

Comment 1

[Drew Willcoxon :adw]

Marco, could we add this to the current iteration, please?

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8446013 [details] [diff] [review]
patch

Review of attachment 8446013 [details] [diff] [review]:
-----------------------------------------------------------------

The 65x26 image is actually 65x25.

Comment 3

[Drew Willcoxon :adw]

Attachment: patch 2

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8446053 [details] [diff] [review]
patch 2

That's better. Thanks.

Comment 5

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/fx-team/rev/5563efd9704c

Comment 6

[Marco Mucci [:MarcoM]]

Added to Iteration 33.2

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5563efd9704c

Comment 8

[Drew Willcoxon :adw]

Comment on attachment 8446053 [details] [diff] [review]
patch 2

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Bug 962490 added a search field to about:newtab and landed on 31.  The logo of the currently selected search engine, if available, appears to the left of the search field.

User impact if declined:
When Google is the currently selected engine, its logo will not appear.  about:newtab gracefully handles missing logos, though.

Testing completed (on m-c, etc.):
manual testing, automated testing on m-c

Risk to taking this patch (and alternatives if risky):
very low

String or IDL/UUID changes made by this patch:
none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d9c6731ad8c3
https://hg.mozilla.org/releases/mozilla-beta/rev/7ffe6a4581dd

Comment 10

[Petruta Horea [:phorea], Desktop QA]

Verified that the Google logo is correctly displayed on Firefox 31 beta 6, Aurora 32.0a2 and Nightly 33.0a1 2014-06-29 on about:newtab page under Win 7 64-bit, Ubutnu 12.10 32-bit and Mac OSX 10.9.3.