1041209 - Unable to add an app to the Featured app and accompanying error message is vague

Status: VERIFIED FIXED

(Marketplace Graveyard :: Curation Tools, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: unable to add an app.png

+++ This bug was initially created as a clone of Bug #1040990 +++

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/curate/create/apps
2. Search for "facebook"
3. Add the other required fields and click Save

expected behavior:
1. App is added and shows up in the Feed preview
2. Error message is clear and accurate

observed behavior:
App is not added and doesn't show up in the Feed Preview
The error message upon clicking "submit" says 'This field is required' which doesn't specify what field is missing

Comment 1

[krupa raj[:krupa]]

Same thing happens for collections as well. Form submissions results in a 400.

Comment 2

[Chuck Harmston [:chuck]]

There are a few bugs here.

The first is that the preview wasn't updating when an app is selected. I just addressed that here:

https://github.com/mozilla/transonic/pull/18

The second is the validation error, which is likely a field whose name was lost in the UX sweep. Let's make this bug about that. I'll take it.

The third is that error messages don't have a very good presentation right now. Can you file a separate bug for that, Krupa?

Comment 3

[Chuck Harmston [:chuck]]

The second bug addressed here: https://github.com/mozilla/transonic/compare/6c91a50ff495...be6b4a988b70

Comment 4

[krupa raj[:krupa]]

(In reply to Chuck Harmston [:chuck] from comment #2)

> The third is that error messages don't have a very good presentation right
> now. Can you file a separate bug for that, Krupa?

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1041699

Comment 5

[krupa raj[:krupa]]

verified fixed at https://marketplace-dev.allizom.org/curate/manage/collections/000~