Closed
Bug 1156352
Opened 9 years ago
Closed 9 years ago
Remove |UnixSocketRawData| from socket I/O interfaces
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S11 (1may)
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(6 files, 1 obsolete file)
7.64 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
13.60 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
4.79 KB,
patch
|
chucklee
:
review+
|
Details | Diff | Splinter Review |
4.43 KB,
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
1.65 KB,
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
20.80 KB,
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
|UnixSocketRawData| is a specific implementation of a socket I/O buffer. The socket I/O classes within Gonk shouldn't use it in their interfaces.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8595224 -
Flags: review?(kyle)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8595225 -
Flags: review?(btian)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8595226 -
Flags: review?(chuckli0706)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8595227 -
Flags: review?(allstars.chh)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8595228 -
Flags: review?(htsai)
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8595229 -
Flags: review?(kyle)
Assignee | ||
Comment 7•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7da36ec9653
Updated•9 years ago
|
Attachment #8595224 -
Flags: review?(kyle) → review+
Comment 8•9 years ago
|
||
Comment on attachment 8595229 [details] [diff] [review] [06] Bug 1156352: Remove |UnixSocketRawData| from socket I/O interfaces Review of attachment 8595229 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bluetooth/bluedroid/BluetoothSocket.h @@ +33,5 @@ > int aChannel); > > void CloseSocket(); > > + void SendSocketData(mozilla::ipc::UnixSocketIOBuffer* aBuffer); Nit: Can mark this as override ::: dom/bluetooth/bluez/BluetoothSocket.h @@ +60,2 @@ > */ > + void SendSocketData(mozilla::ipc::UnixSocketIOBuffer* aBuffer); Nit: Can mark this as override too
Attachment #8595229 -
Flags: review?(kyle) → review+
Comment on attachment 8595226 [details] [diff] [review] [03] Bug 1156352: Remove |UnixSocketRawData| from key store interfaces Review of attachment 8595226 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, thanks!
Attachment #8595226 -
Flags: review?(chuckli0706) → review+
Comment 10•9 years ago
|
||
Comment on attachment 8595225 [details] [diff] [review] [02] Bug 1156352: Remove |UnixSocketRawData| from Bluetooth interfaces Review of attachment 8595225 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8595225 -
Flags: review?(btian) → review+
Attachment #8595227 -
Flags: review?(allstars.chh) → review+
Comment 11•9 years ago
|
||
Comment on attachment 8595228 [details] [diff] [review] [05] Bug 1156352: Remove |UnixSocketRawData| from RIL interfaces Review of attachment 8595228 [details] [diff] [review]: ----------------------------------------------------------------- Thank you :)
Attachment #8595228 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 12•9 years ago
|
||
Changes since v1: - marked |CloseSocket| and |SendSocketData| in |BluetoothSocket| as 'override'
Attachment #8595229 -
Attachment is obsolete: true
Attachment #8596540 -
Flags: review+
Comment 13•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/44f95b98f1b6 https://hg.mozilla.org/integration/b2g-inbound/rev/69e077a03775 https://hg.mozilla.org/integration/b2g-inbound/rev/740b12ba3bca https://hg.mozilla.org/integration/b2g-inbound/rev/045b916983a0 https://hg.mozilla.org/integration/b2g-inbound/rev/271b9895de10 https://hg.mozilla.org/integration/b2g-inbound/rev/67822e71d7ce
Assignee | ||
Comment 14•9 years ago
|
||
Thanks, everyone! https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=67822e71d7ce
Comment 15•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/44f95b98f1b6 https://hg.mozilla.org/mozilla-central/rev/69e077a03775 https://hg.mozilla.org/mozilla-central/rev/740b12ba3bca https://hg.mozilla.org/mozilla-central/rev/045b916983a0 https://hg.mozilla.org/mozilla-central/rev/271b9895de10 https://hg.mozilla.org/mozilla-central/rev/67822e71d7ce
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in
before you can comment on or make changes to this bug.
Description
•