Closed
Bug 1154281
Opened 11 years ago
Closed 11 years ago
Merge |UnixSocketConsumer| into |BluetoothSocket|
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S11 (1may)
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(4 files, 3 obsolete files)
|
901 bytes,
patch
|
allstars.chh
:
review+
|
Details | Diff | Splinter Review |
|
19.35 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
|
20.77 KB,
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
|
10.64 KB,
patch
|
Details | Diff | Splinter Review |
BlueZ's implementation of |BluetoothSocket| is the only remaining user of |UnixSocketConsumer|. Since both classes are supposed to be removed in the long run, we should simply merge |UnixSocketConsumer| into BluetoothSocket.
|
Assignee | |
Comment 1•11 years ago
|
||
Just moves code around and renames some classes.
Attachment #8592748 -
Flags: review?(btian)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8592749 -
Flags: review?(btian)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8592750 -
Flags: review?(allstars.chh)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8592751 -
Flags: review?(kyle)
|
||
Updated•11 years ago
|
Attachment #8592751 -
Flags: review?(kyle) → review+
Attachment #8592750 -
Flags: review?(allstars.chh) → review+
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8592748 [details] [diff] [review]
[01] Bug 1154281: Merge |UnixSocketConsumer| into |BluetoothSocket|
Review of attachment 8592748 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with nit addressed.
::: dom/bluetooth/bluez/BluetoothSocket.cpp
@@ +12,3 @@
> #include "nsThreadUtils.h"
> +#include "nsXULAppAPI.h"
> +#include "mozilla/unused.h"
nit: alphabetical order
Attachment #8592748 -
Flags: review?(btian) → review+
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8592749 [details] [diff] [review]
[02] Bug 1154281: Remove references to UnixSocket.h from Bluetooth
Review of attachment 8592749 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with comment addressed.
::: dom/bluetooth/bluetooth1/ipc/BluetoothServiceChildProcess.h
@@ +13,2 @@
> namespace dom {
> namespace bluetooth {
Replace with |BEGIN_BLUETOOTH_NAMESPACE|.
::: dom/bluetooth/bluetooth2/ipc/BluetoothServiceChildProcess.h
@@ +13,2 @@
> namespace dom {
> namespace bluetooth {
Ditto.
Attachment #8592749 -
Flags: review?(btian) → review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
|
|
Assignee | |
Comment 8•11 years ago
|
||
Changes since v1:
- sort include statements alphabetically
Attachment #8592748 -
Attachment is obsolete: true
Attachment #8595186 -
Flags: review+
|
|
Assignee | |
Comment 9•11 years ago
|
||
Changes since v1:
- using namespace macros
Attachment #8592749 -
Attachment is obsolete: true
Attachment #8595187 -
Flags: review+
|
||
Comment 10•11 years ago
|
||
|
|
Assignee | |
Comment 11•11 years ago
|
||
Changes since v2
- rebased onto bug 1155718
Attachment #8595187 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 12•11 years ago
|
||
|
||
Comment 13•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d2c32fcc1b38
https://hg.mozilla.org/mozilla-central/rev/995b1851e85a
https://hg.mozilla.org/mozilla-central/rev/07ac5145c108
https://hg.mozilla.org/mozilla-central/rev/076bddb037ea
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in
before you can comment on or make changes to this bug.
Description
•