1156352 - Remove |UnixSocketRawData| from socket I/O interfaces

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

|UnixSocketRawData| is a specific implementation of a socket I/O buffer. The socket I/O classes within Gonk shouldn't use it in their interfaces.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1156352: Refactor |UnixSocketIOBuffer|

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1156352: Remove |UnixSocketRawData| from Bluetooth interfaces

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [03] Bug 1156352: Remove |UnixSocketRawData| from key store interfaces

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [04] Bug 1156352: Remove |UnixSocketRawData| from NFC interfaces

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [05] Bug 1156352: Remove |UnixSocketRawData| from RIL interfaces

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [06] Bug 1156352: Remove |UnixSocketRawData| from socket I/O interfaces

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7da36ec9653

Comment 8

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8595229 [details] [diff] [review]
[06] Bug 1156352: Remove |UnixSocketRawData| from socket I/O interfaces

Review of attachment 8595229 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluedroid/BluetoothSocket.h
@@ +33,5 @@
>                      int aChannel);
>  
>    void CloseSocket();
>  
> +  void SendSocketData(mozilla::ipc::UnixSocketIOBuffer* aBuffer);

Nit: Can mark this as override

::: dom/bluetooth/bluez/BluetoothSocket.h
@@ +60,2 @@
>     */
> +  void SendSocketData(mozilla::ipc::UnixSocketIOBuffer* aBuffer);

Nit: Can mark this as override too

Comment 9

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Comment on attachment 8595226 [details] [diff] [review]
[03] Bug 1156352: Remove |UnixSocketRawData| from key store interfaces

Review of attachment 8595226 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!

Comment 10

[Ben Tian (inactive)]

Comment on attachment 8595225 [details] [diff] [review]
[02] Bug 1156352: Remove |UnixSocketRawData| from Bluetooth interfaces

Review of attachment 8595225 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8595228 [details] [diff] [review]
[05] Bug 1156352: Remove |UnixSocketRawData| from RIL interfaces

Review of attachment 8595228 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)

Comment 12

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [06] Bug 1156352: Remove |UnixSocketRawData| from socket I/O interfaces (v2)

Changes since v1:

  - marked |CloseSocket| and |SendSocketData| in |BluetoothSocket| as 'override'

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/44f95b98f1b6
https://hg.mozilla.org/integration/b2g-inbound/rev/69e077a03775
https://hg.mozilla.org/integration/b2g-inbound/rev/740b12ba3bca
https://hg.mozilla.org/integration/b2g-inbound/rev/045b916983a0
https://hg.mozilla.org/integration/b2g-inbound/rev/271b9895de10
https://hg.mozilla.org/integration/b2g-inbound/rev/67822e71d7ce

Comment 14

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks, everyone!

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=67822e71d7ce

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/44f95b98f1b6
https://hg.mozilla.org/mozilla-central/rev/69e077a03775
https://hg.mozilla.org/mozilla-central/rev/740b12ba3bca
https://hg.mozilla.org/mozilla-central/rev/045b916983a0
https://hg.mozilla.org/mozilla-central/rev/271b9895de10
https://hg.mozilla.org/mozilla-central/rev/67822e71d7ce