Closed Bug 1156352 Opened 9 years ago Closed 9 years ago

Remove |UnixSocketRawData| from socket I/O interfaces

Categories

(Firefox OS Graveyard :: General, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
2.2 S11 (1may)
Tracking Status
firefox40 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(6 files, 1 obsolete file)

|UnixSocketRawData| is a specific implementation of a socket I/O buffer. The socket I/O classes within Gonk shouldn't use it in their interfaces.
Attachment #8595224 - Flags: review?(kyle) → review+
Comment on attachment 8595229 [details] [diff] [review]
[06] Bug 1156352: Remove |UnixSocketRawData| from socket I/O interfaces

Review of attachment 8595229 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluedroid/BluetoothSocket.h
@@ +33,5 @@
>                      int aChannel);
>  
>    void CloseSocket();
>  
> +  void SendSocketData(mozilla::ipc::UnixSocketIOBuffer* aBuffer);

Nit: Can mark this as override

::: dom/bluetooth/bluez/BluetoothSocket.h
@@ +60,2 @@
>     */
> +  void SendSocketData(mozilla::ipc::UnixSocketIOBuffer* aBuffer);

Nit: Can mark this as override too
Attachment #8595229 - Flags: review?(kyle) → review+
Comment on attachment 8595226 [details] [diff] [review]
[03] Bug 1156352: Remove |UnixSocketRawData| from key store interfaces

Review of attachment 8595226 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!
Attachment #8595226 - Flags: review?(chuckli0706) → review+
Comment on attachment 8595225 [details] [diff] [review]
[02] Bug 1156352: Remove |UnixSocketRawData| from Bluetooth interfaces

Review of attachment 8595225 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8595225 - Flags: review?(btian) → review+
Attachment #8595227 - Flags: review?(allstars.chh) → review+
Comment on attachment 8595228 [details] [diff] [review]
[05] Bug 1156352: Remove |UnixSocketRawData| from RIL interfaces

Review of attachment 8595228 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)
Attachment #8595228 - Flags: review?(htsai) → review+
Changes since v1:

  - marked |CloseSocket| and |SendSocketData| in |BluetoothSocket| as 'override'
Attachment #8595229 - Attachment is obsolete: true
Attachment #8596540 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: