Remove |UnixSocketRawData| from socket I/O interfaces

RESOLVED FIXED in Firefox 40

Status

Firefox OS
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

unspecified
2.2 S11 (1may)
All
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(6 attachments, 1 obsolete attachment)

|UnixSocketRawData| is a specific implementation of a socket I/O buffer. The socket I/O classes within Gonk shouldn't use it in their interfaces.
Created attachment 8595224 [details] [diff] [review]
[01] Bug 1156352: Refactor |UnixSocketIOBuffer|
Attachment #8595224 - Flags: review?(kyle)
Created attachment 8595225 [details] [diff] [review]
[02] Bug 1156352: Remove |UnixSocketRawData| from Bluetooth interfaces
Attachment #8595225 - Flags: review?(btian)
Created attachment 8595226 [details] [diff] [review]
[03] Bug 1156352: Remove |UnixSocketRawData| from key store interfaces
Attachment #8595226 - Flags: review?(chuckli0706)
Created attachment 8595227 [details] [diff] [review]
[04] Bug 1156352: Remove |UnixSocketRawData| from NFC interfaces
Attachment #8595227 - Flags: review?(allstars.chh)
Created attachment 8595228 [details] [diff] [review]
[05] Bug 1156352: Remove |UnixSocketRawData| from RIL interfaces
Attachment #8595228 - Flags: review?(htsai)
Created attachment 8595229 [details] [diff] [review]
[06] Bug 1156352: Remove |UnixSocketRawData| from socket I/O interfaces
Attachment #8595229 - Flags: review?(kyle)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7da36ec9653
Attachment #8595224 - Flags: review?(kyle) → review+
Comment on attachment 8595229 [details] [diff] [review]
[06] Bug 1156352: Remove |UnixSocketRawData| from socket I/O interfaces

Review of attachment 8595229 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluedroid/BluetoothSocket.h
@@ +33,5 @@
>                      int aChannel);
>  
>    void CloseSocket();
>  
> +  void SendSocketData(mozilla::ipc::UnixSocketIOBuffer* aBuffer);

Nit: Can mark this as override

::: dom/bluetooth/bluez/BluetoothSocket.h
@@ +60,2 @@
>     */
> +  void SendSocketData(mozilla::ipc::UnixSocketIOBuffer* aBuffer);

Nit: Can mark this as override too
Attachment #8595229 - Flags: review?(kyle) → review+
Comment on attachment 8595226 [details] [diff] [review]
[03] Bug 1156352: Remove |UnixSocketRawData| from key store interfaces

Review of attachment 8595226 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!
Attachment #8595226 - Flags: review?(chuckli0706) → review+

Comment 10

3 years ago
Comment on attachment 8595225 [details] [diff] [review]
[02] Bug 1156352: Remove |UnixSocketRawData| from Bluetooth interfaces

Review of attachment 8595225 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8595225 - Flags: review?(btian) → review+
Attachment #8595227 - Flags: review?(allstars.chh) → review+
Comment on attachment 8595228 [details] [diff] [review]
[05] Bug 1156352: Remove |UnixSocketRawData| from RIL interfaces

Review of attachment 8595228 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)
Attachment #8595228 - Flags: review?(htsai) → review+
Created attachment 8596540 [details] [diff] [review]
[06] Bug 1156352: Remove |UnixSocketRawData| from socket I/O interfaces (v2)

Changes since v1:

  - marked |CloseSocket| and |SendSocketData| in |BluetoothSocket| as 'override'
Attachment #8595229 - Attachment is obsolete: true
Attachment #8596540 - Flags: review+

Comment 13

3 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/44f95b98f1b6
https://hg.mozilla.org/integration/b2g-inbound/rev/69e077a03775
https://hg.mozilla.org/integration/b2g-inbound/rev/740b12ba3bca
https://hg.mozilla.org/integration/b2g-inbound/rev/045b916983a0
https://hg.mozilla.org/integration/b2g-inbound/rev/271b9895de10
https://hg.mozilla.org/integration/b2g-inbound/rev/67822e71d7ce
Thanks, everyone!

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=67822e71d7ce
https://hg.mozilla.org/mozilla-central/rev/44f95b98f1b6
https://hg.mozilla.org/mozilla-central/rev/69e077a03775
https://hg.mozilla.org/mozilla-central/rev/740b12ba3bca
https://hg.mozilla.org/mozilla-central/rev/045b916983a0
https://hg.mozilla.org/mozilla-central/rev/271b9895de10
https://hg.mozilla.org/mozilla-central/rev/67822e71d7ce
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in before you can comment on or make changes to this bug.