1170667 - Red warning "not for your platform" flashes briefly when I click to app details page

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Caitlin Galimidi [:c8o]]

I pull up marketplace on desktop production

I click on any app on the homepage
(tried: Wordpress, Tapthebest, Road Crossing)

When the page loads I see the red "not available for your platform" message flash on the screen quickly and then it goes away

Expected: the red warning message should not be visible at all as the app details page loads


(on a mac, firefox 38.0.5)

Comment 1

[Kevin Ngo [:ngoke]]

A placeholder_app is set in apps/views.js which is sent to templates/app/index.html which renders detail_header from _macros/detail.html which sends a placeholder app into app_tile.html in _macros/app_tile.html.

Make app_tile.html not render the message while it's rendering the placeholder app.

Comment 2

[ankursmooth]

hey can i try solve this bug

Comment 3

[erhitesh10]

(In reply to ankursmooth from comment #2)
> hey can i try solve this bug

Hey Can i Try to fix it if you are not doing ?

Comment 4

[ankursmooth]

(In reply to ankursmooth from comment #2)
> hey can i try solve this bug

Comment 5

[tarungupta.y12]

if both of u are not doing it, shall I proceed?

Comment 6

[Ram Dayal Vaishnav [:ram]]

Assigning this to Ayush, Thanks

Comment 7

[Ram Dayal Vaishnav [:ram]]

(In reply to Ram Dayal Vaishnav [:ramd] from comment #6)
> Assigning this to Ayush, Thanks

Assigned this to Ankur, sorry for typo.

Comment 8

[Ram Dayal Vaishnav [:ram]]

Hi Ankur, if you need any specific please mention here while raising the needinfo flag. Clearing the flag for now, feel free to raise the flag or catch engineers on #marketplace on irc.mozilla.org for any help.

Comment 9

[Mark Striemer [:mstriemer]]

You should be able to set `notices = []` in [1] if the app's slug in `loading` (which comes from [2]).

> {% set notices = [] if app.slug == 'loading' else app_notices(app) %}

[1] https://github.com/mozilla/fireplace/blob/65a024b449d981e9019f1eabbf2ed4f70491a45a/src/templates/_macros/app_tile.html#L71
[2] https://github.com/mozilla/fireplace/blob/65a024b449d981e9019f1eabbf2ed4f70491a45a/src/media/js/views/app.js#L35

Comment 10

[ankursmooth]

thanks Mark Striemer[:mstriemer].
i have done it and tested it.
please look into pull request number #1456

Comment 11

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/fireplace/commit/3050f509707391b1497c0ef24ee1d00ec20dd4c7