1465544 - Add the 'mozillaAddons' Permission to Screenshots

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect)

Description

[Barry Chen]

Bug 1456485 introduced a new addon permission, 'mozillaAddons', that needs to be in Screenshots.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Note that we need this on ESR60 and Beta as well.

Comment 2

[Barry Chen]

Attachment: Bug 1465544 - Add 'mozillaAddons' permission to Screenshots;

Review commit: https://reviewboard.mozilla.org/r/247990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247990/

Comment 3

[Ian Bicking (:ianbicking)]

Comment on attachment 8981972 [details]
Bug 1465544 - Add 'mozillaAddons' permission to Screenshots;

https://reviewboard.mozilla.org/r/247990/#review254116

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8981972 [details]
Bug 1465544 - Add 'mozillaAddons' permission to Screenshots;

https://reviewboard.mozilla.org/r/247990/#review254120

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04e69f74afe1
Add 'mozillaAddons' permission to Screenshots; r=ianbicking,_6a68

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/04e69f74afe1

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please request Beta & ESR60 approval on this patch.

Comment 8

[Barry Chen]

Comment on attachment 8981972 [details]
Bug 1465544 - Add 'mozillaAddons' permission to Screenshots;

> Approval Request Comment
> [Feature/Bug causing the regression]:
Bug 1456485 and bug 1466349.

> [User impact if declined]:
Users will not be able to take screenshots of PDFs with Firefox Screenshots.

> [Is this code covered by automated tests?]:
No, in that there's no full integration testing for capturing a shot of a PDF page.

> [Has the fix been verified in Nightly?]:
No.

> [Needs manual test from QE? If yes, steps to reproduce]: 
Yes. Bug 1456485 has the STR.

> [List of other uplifts needed for the feature/fix]:
Bug 1456485 and bug 1466349.

> [Is the change risky?]:
For Screenshots itself, no.  It fixes a regression.  See bug 1456485 for discussion on potential risks.

> [Why is the change risky/not risky?]:
It allows system addons to access protected pages. See bug 1456485.

> [String changes made/needed]:
No.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8981972 [details]
Bug 1465544 - Add 'mozillaAddons' permission to Screenshots;

Required fix to get Screenshots working again with various privileged pages (PDF Viewer, Reader Mode, etc). Approved for 61.0b12 and ESR 60.1.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f97d4447e802

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/c5161c79c50b

Comment 12

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly (62.0a1 Build ID: 20180617220505) and latest Beta (61.0b14 Build ID: 20180614135649) and the issue is no longer reproducible.
Tested on Windows 7 x64, Windows 10 x64, Mac Os 10.13 and Arch Linux.

The issue is still reproducible on Firefox ESR 60.0 because of bug 1467924 that should also be uplifted in ESR 60 (see bug 1467924 comment 10).

Comment 13

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified the issue on latest ESR (60.1.0, Build ID 20180621121604) and the issue is no longer reproducible. Tested on Windows 10 x64, Windows 7 x64, Mac 10.13 and Arch Linux 4.12.