1467924 - Correctly calculate extension install locations at startup

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Kris Maglione [:kmag]]

We currently only correctly determine the install location of add-ons when calling bootstrap methods when we pass a DB add-on. When passing an XPIState, we completely ignore it, which means that we can't correctly detect built-in add-ons at app startup.

This is not an issue in nightlies, since it was fixed during some other refactorings.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1467924: Correctly calculate add-on install location at startup.

Review commit: https://reviewboard.mozilla.org/r/250496/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250496/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8984609 [details]
Bug 1467924: Correctly calculate add-on install location at startup.

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: This prevents us from shipping built-in add-ons which require special privileges unless they're also signed (which built-in add-ons currently are not). In particular, it prevents the Screenshots system add-on from working on privileged pages, such as PDF.js
[Is this code covered by automated tests?]: Yes, though this particular issue is not.
[Has the fix been verified in Nightly?]: No, nightly is not affected by this bug, but I verified in a local beta build.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low-risk
[Why is the change risky/not risky?]: It's trivial, and simply fixes our check for extension install locations at startup time.
[String changes made/needed]: None.

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8984609 [details]
Bug 1467924: Correctly calculate add-on install location at startup.

https://reviewboard.mozilla.org/r/250496/#review256760

This looks right, I assume its been verified manually?

Comment 4

[(PTO June 19-July 7) Ryan VanderMeulen]

Comment on attachment 8984609 [details]
Bug 1467924: Correctly calculate add-on install location at startup.

Approved for 61.0b13 and ESR 60.1.

Comment 5

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-beta/rev/7a64cce0e120

I can confirm that builds off this Beta revision have properly-functioning screenshotting abilities :). Will leave qe-verify+ set for SV to do the full round of testing, though.

Comment 6

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-esr60/rev/9bdbe902cb7e

Comment 7

[Cristian Baica [:cbaica], Release Desktop QA]

Since this needs a QE verification, Kris, could you please provide some steps on how to calculate add-on install locations at startup?
As far as I understand from the comments left here, this issue affected screenshotting of PDF files, but that is tracked in a separate ticket 1456485.
Should I just check for that functionality, or is there something else that needs to be verified?

Comment 8

[Kris Maglione [:kmag]]

See bug 1456485

Comment 9

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on latest Beta 61.0b13 (Build ID: 20180611134439) and the issue is no longer reproducible. Firefox screenshots works on pdf pages. Tested on Windows 7 x64, Windows 10 x64, Mac 10.13 and Arch Linux 4.12.

I have also verified this on ESR 60.0.3 (Build ID: 20180609160107) but the issue is still reproducible. I have tested this on the build downloaded from here: https://treeherder.mozilla.org/#/jobs?repo=mozilla-esr60&revision=7d96e64a45748da951ebcb6a30d99b7156494bec
Tested on Windows 7 x64, Windows 10 x64, Mac 10.13 and Arch Linux 4.12.

Kris, can you please take a look over this? I have verified the issue on the wrong ESR build?

Comment 10

[Kris Maglione [:kmag]]

Heh. It looks like we'd have to uplift bug 1454820 to ESR60 to get this working there.

Comment 11

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified the issue on latest ESR (60.1.0, Build ID 20180619173714) and the issue is no longer reproducible. Tested on Windows 10 x64, Windows 7 x64, Mac 10.13 and Arch Linux 4.12.