372806 - Required fields that are localized are not enforced consistently

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Wladimir Palant]

When I upload a new add-on version and don't provide version notes in step 2 I get an error message. However, I can enter something and remove it in step 4 again - no check there.

Comment 1

[Justin Scott [:fligtar]]

This is true for any required field that is localized (most of them). Ideally, required fields would be checked for the default locale anytime saveTranslations() is called.

Forgot to copy this bug from grouphub.

Comment 3

[Fred Wenzel [:wenzel]]

Is this problem even present anymore in the new dev CP? From what I see in the UI, I am unable to remove the default language from the translation fields, unlike in the old version.

If I still need to add something to saveTranslations(), where do I get a set of "required" fields?

Comment 4

[Fred Wenzel [:wenzel]]

For all I can see for now, it is fixed in the new dev cp.

Comment 5

[Dave Garrett]

^will be fixed, when the new dev cp is default. Any idea when the old system will be removed and fully replaced with the new?

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified; always one required locale.

Wil knows more, but I think in the next milestone; we had some l10n to get out of the way, first (putting comments by each string define, iirc).