396463 - Text referencing Talkback in about:license should be removed

Status: RESOLVED FIXED

(Firefox :: General, defect, P5)

Description

[AndrewM]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007091504 Minefield/3.0a8pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007091504 Minefield/3.0a8pre

It is my understanding that the Talkback component has been permanently replaced by the Breakpad crash reporter. Therefore, the text on the about:license page (under 'Exceptions') pertaining to Talkback should be removed because it is no longer included. It reads:
"The Talkback crash-reporting module (Copyright ©1998-2005 SupportSoft, Inc. All Rights Reserved.)"

Reproducible: Always

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Paint it red, v.1

Best <del>bikeshed</del> <ins>blocker</ins> evar!

Some things to note:

* Doing this will block Camino from switching from the copy in xpfe to this copy. Almost certainly not a problem, since they are more likely to muster the resources to fix bug 380172 than they are to fix bug 368091, but there's also no reasonable way to remind them, short of filing a bug on them to switch license files, solely to mark it blocked by bug 380172.

* Gerv is of the opinion that he can make unreviewed checkins to sync the multiple copies of this file. Probably an accidental change to the "official binaries" line in the xpfe copy would be noticed, and thus an accidental change to remove that copy's Talkback line would, too. Probably.

* There is absolutely no need to do this, whatsoever. None at all. The license says "may include" not "must include, or something's wrong and you get sue and can use every bit under whatever terms you want."

* Having  a single, plural, line item under "the following portions" is just begging for grammatical bikeshedding, as would be "the following portion." I think adding something else non-Free is more likely than not, so I didn't recast it into a single sentence about the images, but I would certainly entertain (and be entertained by) a discussion of the relative merits of the two approaches.

Comment 2

[Phil Ringnalda (:philor)]

Gerv - note the aspersions about your character and habits in comment 1

Reed - note the opportunities for grammatical bikeshedding :)

Comment 3

[Phil Ringnalda (:philor)]

Oh, and there's the Sunbird situation: they don't successfully display any license, last I looked, but they might possibly jar this one up; bug 374235 isn't entirely instructive about the current state of their switch to Breakpad.

Comment 4

[Gervase Markham [:gerv]]

Phil's right - we can fix this when we are good and sure that no-one's using Talkback any more. If people can get that data from all the sub-projects, then I'm fine with it.

Gerv

Comment 5

[AndrewM]

One more thing I noticed on about:license; there is no mention of Breakpad being licensed under the New BSD License. Should there be?

Comment 6

[Gervase Markham [:gerv]]

AndrewM: If it's part of the build, and the license requires copies of itself to be available in "the Software" or in documentation, then yes. Please file a bug and I'll fix it.

Gerv

Comment 7

[AndrewM]

(In reply to comment #6)
> AndrewM: If it's part of the build, and the license requires copies of itself
> to be available in "the Software" or in documentation, then yes. Please file a
> bug and I'll fix it.
> 
> Gerv

Filed bug 400520.

Comment 8

[AndrewM]

Fixed in bug 414025.