517805 - Move printDialog to calendar/base/content

Status: RESOLVED FIXED

(Calendar :: Printing, defect)

Description

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

Changes in this patch:

* Cleanup of printDialog.xul/js: braces, space, indentation, use 'let'

* Remove unused vars gPrintSettings and contractids (printDialog.js)

* Replace usage of string bundle with calGetString(...)

* Remove unused stylesheets, overlay and CSS class (printDialog.xul)

* Move printDialog.xul/js to calendar-print-dialog.xul/js in calendar/base/content/dialogs/ and change jar.mn & calUtils.js accordingly.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 401766 [details] [diff] [review]
Patch v1

>+    let catenum = catman.enumerateCategory("cal-print-formatters");
> 
>     // Walk the list, adding items to the layout menupopup
>+    let layoutList = document.getElementById("layout-field");
>     while (catenum.hasMoreElements()) {
>+        let entry = catenum.getNext();
You may want to use iteratorUtils here, then you can just do for each (fixIterator(catman.enumerateCategory("cal-print-formatters")) {} or similar. Not sure if we've included this into Sunbird yet though.


Anyway, r=philipp

Comment 3

[Martin Schröder [:mschroeder]]

http://hg.mozilla.org/comm-central/rev/1cee73f0baea
http://hg.mozilla.org/releases/comm-1.9.1/rev/ff573f5bced9