Closed
Bug 535604
Opened 15 years ago
Closed 14 years ago
Search should index tiki_pages.keywords
Categories
(support.mozilla.org :: Search, defect)
support.mozilla.org
Search
Tracking
(Not tracked)
VERIFIED
FIXED
1.5.2
People
(Reporter: jsocol, Assigned: jsocol)
References
()
Details
(Whiteboard: sumo_only search)
Attachments
(3 files)
The wiki_pages source in sphinx.conf does not include the tiki_pages.keywords column. Small oversight and easy fix. This column doesn't need to be an attribute, just included in the index.
Comment 1•15 years ago
|
||
1.5.1 worthy?
Updated•15 years ago
|
Target Milestone: --- → 1.5.1
Assignee | ||
Comment 3•15 years ago
|
||
One-liner.* A good way to test is to use tiki-admin_keywords.php to add some strange keyword that should not appear anywhere else, run the indexer, and then search for that keyword. I used the name of an obscure character from Star Wars, because I am a huge nerd. * I was planning on using this for my "your first patch" screencast, but I decided I'd rather use something with a more immediately visible change.
Attachment #418672 -
Flags: review?(paulc)
Comment 4•15 years ago
|
||
Comment on attachment 418672 [details] [diff] [review] add keywords to source query Hm, I followed your advice but still don't see the page in the search results. I may be doing it wrong. Should keywords be added to the content?
Assignee | ||
Comment 5•15 years ago
|
||
(In reply to comment #4) > Should keywords be added to the content? Not quite sure what you mean there. Can you clarify? Here's basically my steps to test: 1. Apply patch to active sphinx.conf file. (May need to restart searchd? But shouldn't.) 2. Head to tiki-admin_keywords.php, pick a random article, add the keyword "monmothma" (or the obscure Star Wars character of your choice) and save it. Keywords seem to be space delimited, but that doesn't really matter in this case. 3. Reindex with the patched sphinx.conf. 4. Search for "monmothma". (Hopefully) Just one article will show up. tiki_pages.keywords is just a simple text field. This patch just adds it to the list of indexed fields (not as an attribute or anything).
Comment 6•15 years ago
|
||
That's what I thought I did, but it's entirely possible I overlooked something. I will try again now.
Comment 7•15 years ago
|
||
Comment on attachment 418672 [details] [diff] [review] add keywords to source query WFM. Of course, I missed the obvious -- I wasn't using the right db on indexing. Oops.
Attachment #418672 -
Flags: review?(paulc) → review+
Assignee | ||
Comment 8•15 years ago
|
||
r58907 Give it a little while to pick up the new indices.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 9•15 years ago
|
||
Verified FIXED on https://support-stage.mozilla.org/search.php?where=all&locale=en-US&qs=s&q=monmothma&sa=Search
Status: RESOLVED → VERIFIED
Assignee | ||
Updated•14 years ago
|
Status: VERIFIED → RESOLVED
Closed: 15 years ago → 14 years ago
Assignee | ||
Comment 12•14 years ago
|
||
Reopening to commit to branches/1.5.1_temp. Will re-resolve after patches are committed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 13•14 years ago
|
||
On branch, r62439.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 1.5.1 → 1.5.2
Assignee | ||
Comment 14•14 years ago
|
||
There is some bug here that affects this on stage--neither Paul nor I can reproduce it locally. To aid in debugging, I've filed bug 546757. Unfortunately, given the tight schedule of 1.5.1, we're waiting until after the push to get that done. This doesn't break anything, it just doesn't seem to work quite right on stage, and without the ability to debug it or reproduce the issue locally, we're stuck.
Depends on: 546757
Updated•14 years ago
|
Target Milestone: 1.5.2 → 1.5.3
Assignee | ||
Comment 15•14 years ago
|
||
There does seem to be some lag, and it feels like sometimes you need to start the search over (looking via the advanced search wasn't working, but as soon as I just typed "harrypotter" back into the sidebar search the article magically appeared), but it is working. Weird.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Target Milestone: 1.5.3 → 1.5.2
Verified FIXED, on both https://support-stage.mozilla.com/search.php?where=all&locale=en-US&qs=s&q=ilovelexus&sa=Search and https://support-stage.mozilla.org/search.php?where=all&locale=en-US&qs=s&q=monmothma&sa=Search
Status: RESOLVED → VERIFIED
Comment 17•14 years ago
|
||
I added "monmotha" as a keyword for the Site Identity Button article on prod, so we can test this.
(In reply to comment #17) > I added "monmotha" as a keyword for the Site Identity Button article on prod, > so we can test this. When this returns a result, we'll know if it worked: http://support.mozilla.com/search.php?where=all&locale=en-US&qs=s&q=monmotha&sa=Search
You need to log in
before you can comment on or make changes to this bug.
Description
•