Search should index tiki_pages.keywords

VERIFIED FIXED in 1.5.2

Status

support.mozilla.org
Search
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: jsocol, Assigned: jsocol)

Tracking

unspecified
1.5.2

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: sumo_only search, URL)

Attachments

(3 attachments)

(Assignee)

Description

9 years ago
The wiki_pages source in sphinx.conf does not include the tiki_pages.keywords column. Small oversight and easy fix.

This column doesn't need to be an attribute, just included in the index.
1.5.1 worthy?
(Assignee)

Comment 2

9 years ago
Yeah, very easy.
Assignee: nobody → james

Updated

9 years ago
Target Milestone: --- → 1.5.1
(Assignee)

Comment 3

9 years ago
Created attachment 418672 [details] [diff] [review]
add keywords to source query

One-liner.* 

A good way to test is to use tiki-admin_keywords.php to add some strange keyword that should not appear anywhere else, run the indexer, and then search for that keyword. I used the name of an obscure character from Star Wars, because I am a huge nerd.

* I was planning on using this for my "your first patch" screencast, but I decided I'd rather use something with a more immediately visible change.
Attachment #418672 - Flags: review?(paulc)
Comment on attachment 418672 [details] [diff] [review]
add keywords to source query

Hm, I followed your advice but still don't see the page in the search results. I may be doing it wrong.

Should keywords be added to the content?
(Assignee)

Comment 5

9 years ago
(In reply to comment #4)
> Should keywords be added to the content?

Not quite sure what you mean there. Can you clarify?

Here's basically my steps to test:

1. Apply patch to active sphinx.conf file. (May need to restart searchd? But shouldn't.)
2. Head to tiki-admin_keywords.php, pick a random article, add the keyword "monmothma" (or the obscure Star Wars character of your choice) and save it. Keywords seem to be space delimited, but that doesn't really matter in this case.
3. Reindex with the patched sphinx.conf.
4. Search for "monmothma". (Hopefully) Just one article will show up.

tiki_pages.keywords is just a simple text field. This patch just adds it to the list of indexed fields (not as an attribute or anything).
That's what I thought I did, but it's entirely possible I overlooked something. I will try again now.
Comment on attachment 418672 [details] [diff] [review]
add keywords to source query

WFM. Of course, I missed the obvious -- I wasn't using the right db on indexing. Oops.
Attachment #418672 - Flags: review?(paulc) → review+
(Assignee)

Comment 8

9 years ago
r58907

Give it a little while to pick up the new indices.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Created attachment 421868 [details]
Post-fix screenshot of the setup -- added "monmothma"
Created attachment 421869 [details]
Post-fix screenshot, verification; searching for "monmotha"
(Assignee)

Updated

9 years ago
Status: VERIFIED → RESOLVED
Last Resolved: 9 years ago9 years ago
(Assignee)

Comment 12

9 years ago
Reopening to commit to branches/1.5.1_temp. Will re-resolve after patches are committed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 13

9 years ago
On branch, r62439.
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 1.5.1 → 1.5.2
(Assignee)

Comment 14

9 years ago
There is some bug here that affects this on stage--neither Paul nor I can reproduce it locally.

To aid in debugging, I've filed bug 546757. Unfortunately, given the tight schedule of 1.5.1, we're waiting until after the push to get that done.

This doesn't break anything, it just doesn't seem to work quite right on stage, and without the ability to debug it or reproduce the issue locally, we're stuck.
Depends on: 546757

Updated

9 years ago
Target Milestone: 1.5.2 → 1.5.3
(Assignee)

Comment 15

9 years ago
There does seem to be some lag, and it feels like sometimes you need to start the search over (looking via the advanced search wasn't working, but as soon as I just typed "harrypotter" back into the sidebar search the article magically appeared), but it is working. Weird.
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Target Milestone: 1.5.3 → 1.5.2
I added "monmotha" as a keyword for the Site Identity Button article on prod, so we can test this.
(In reply to comment #17)
> I added "monmotha" as a keyword for the Site Identity Button article on prod,
> so we can test this.

When this returns a result, we'll know if it worked: http://support.mozilla.com/search.php?where=all&locale=en-US&qs=s&q=monmotha&sa=Search
You need to log in before you can comment on or make changes to this bug.