535604 - Search should index tiki_pages.keywords

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect)

Description

[James Socol [:jsocol, :james]]

The wiki_pages source in sphinx.conf does not include the tiki_pages.keywords column. Small oversight and easy fix.

This column doesn't need to be an attribute, just included in the index.

Comment 1

[Chris Ilias [:cilias]]

1.5.1 worthy?

Comment 2

[James Socol [:jsocol, :james]]

Yeah, very easy.

Comment 3

[James Socol [:jsocol, :james]]

Attachment: add keywords to source query

One-liner.* 

A good way to test is to use tiki-admin_keywords.php to add some strange keyword that should not appear anywhere else, run the indexer, and then search for that keyword. I used the name of an obscure character from Star Wars, because I am a huge nerd.

* I was planning on using this for my "your first patch" screencast, but I decided I'd rather use something with a more immediately visible change.

Comment 4

[Paul Craciunoiu [:paulc]]

Comment on attachment 418672 [details] [diff] [review]
add keywords to source query

Hm, I followed your advice but still don't see the page in the search results. I may be doing it wrong.

Should keywords be added to the content?

Comment 5

[James Socol [:jsocol, :james]]

(In reply to comment #4)
> Should keywords be added to the content?

Not quite sure what you mean there. Can you clarify?

Here's basically my steps to test:

1. Apply patch to active sphinx.conf file. (May need to restart searchd? But shouldn't.)
2. Head to tiki-admin_keywords.php, pick a random article, add the keyword "monmothma" (or the obscure Star Wars character of your choice) and save it. Keywords seem to be space delimited, but that doesn't really matter in this case.
3. Reindex with the patched sphinx.conf.
4. Search for "monmothma". (Hopefully) Just one article will show up.

tiki_pages.keywords is just a simple text field. This patch just adds it to the list of indexed fields (not as an attribute or anything).

Comment 6

[Paul Craciunoiu [:paulc]]

That's what I thought I did, but it's entirely possible I overlooked something. I will try again now.

Comment 7

[Paul Craciunoiu [:paulc]]

Comment on attachment 418672 [details] [diff] [review]
add keywords to source query

WFM. Of course, I missed the obvious -- I wasn't using the right db on indexing. Oops.

Comment 8

[James Socol [:jsocol, :james]]

r58907

Give it a little while to pick up the new indices.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot of the setup -- added "monmothma"

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot, verification; searching for "monmotha"

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://support-stage.mozilla.org/search.php?where=all&locale=en-US&qs=s&q=monmothma&sa=Search

Comment 12

[James Socol [:jsocol, :james]]

Reopening to commit to branches/1.5.1_temp. Will re-resolve after patches are committed.

Comment 13

[James Socol [:jsocol, :james]]

On branch, r62439.

Comment 14

[James Socol [:jsocol, :james]]

There is some bug here that affects this on stage--neither Paul nor I can reproduce it locally.

To aid in debugging, I've filed bug 546757. Unfortunately, given the tight schedule of 1.5.1, we're waiting until after the push to get that done.

This doesn't break anything, it just doesn't seem to work quite right on stage, and without the ability to debug it or reproduce the issue locally, we're stuck.

Comment 15

[James Socol [:jsocol, :james]]

There does seem to be some lag, and it feels like sometimes you need to start the search over (looking via the advanced search wasn't working, but as soon as I just typed "harrypotter" back into the sidebar search the article magically appeared), but it is working. Weird.

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED, on both https://support-stage.mozilla.com/search.php?where=all&locale=en-US&qs=s&q=ilovelexus&sa=Search and https://support-stage.mozilla.org/search.php?where=all&locale=en-US&qs=s&q=monmothma&sa=Search

Comment 17

[Chris Ilias [:cilias]]

I added "monmotha" as a keyword for the Site Identity Button article on prod, so we can test this.

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #17)
> I added "monmotha" as a keyword for the Site Identity Button article on prod,
> so we can test this.

When this returns a result, we'll know if it worked: http://support.mozilla.com/search.php?where=all&locale=en-US&qs=s&q=monmotha&sa=Search