Closed
Bug 714510
Opened 13 years ago
Closed 13 years ago
Viewpickerlabel has a white background on normal toolbars
Categories
(Thunderbird :: Toolbars and Tabs, defect)
Tracking
(thunderbird11 fixed)
RESOLVED
FIXED
Thunderbird 12.0
| Tracking | Status | |
|---|---|---|
| thunderbird11 | --- | fixed |
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(2 files)
|
1.88 KB,
image/png
|
Details | |
|
511 bytes,
patch
|
mconley
:
review+
mconley
:
ui-review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Screenshot showing the issue
The viewpickerlabel has a white background to be better readable. Now with the tabs on top only the tabbar-toolbar is transparent. On other toolbars this background looks odd.
|
Assignee | |
Comment 1•13 years ago
|
||
This patch changes to show the white background only on the tabbar-toolbar. This is now the only transparent toolbar.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #585195 -
Flags: ui-review?(mconley)
Attachment #585195 -
Flags: review?(mconley)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 585195 [details] [diff] [review] Use the background only on tabbar-toolbar Fixes the problem for me, and the code looks good. Thanks! -Mike
Attachment #585195 -
Flags: ui-review?(mconley)
Attachment #585195 -
Flags: ui-review+
Attachment #585195 -
Flags: review?(mconley)
Attachment #585195 -
Flags: review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 585195 [details] [diff] [review] Use the background only on tabbar-toolbar Asking for approval because the same issue is on aurora
Attachment #585195 -
Flags: approval-comm-aurora?
|
|
||
Updated•13 years ago
|
tracking-thunderbird11:
--- → ?
|
|
||
Comment 5•13 years ago
|
||
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/3d61a0034ce1
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
|
||
Updated•13 years ago
|
Attachment #585195 -
Flags: approval-comm-aurora? → approval-comm-aurora+
|
|
||
Comment 6•13 years ago
|
||
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/83b039581185
status-thunderbird11:
--- → fixed
|
|
||
Updated•13 years ago
|
tracking-thunderbird11:
? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•