735652 - viewport incorrect on maps.google.com

Status: RESOLVED DUPLICATE of bug 753742

(Firefox for Android Graveyard :: General, defect)

Description

[Catalin Suciu [:csuciu]]

Attachment: Screenshot

Maple nightly 13.0a1 2012-03-14 (20120314040210)
Samsung Galaxy SII (Android 2.3.4)

Steps:
1. Load maps.google.com. 
   The desktop version of the site is loaded. A fraction of the map is    displayed on the right part of the screen. 
2. Try to pan the page to the left, to see the entire map

Expected:
The page can be panned

Actual:
The page can't be panned

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

This seems like a dupe of bug 724160

Comment 2

[Wesley Johnston (:wesj)]

Google prevents panning on their desktop site, regardless of where the pan begins. We are just doing what they ask. The bug here is that the default viewport seems wrong? Either the site should be laid out wider, or we are not setting the zoom factor to fit it all on screen.

bug 724160 is a meta bug for touch events issues.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I agree with what wesj said above. I'll take a look at how we're calculating the viewport. Might be related to bug 732119; it seems like when there's canvas or other kinds of "object" elements on the page we don't get the right page size.

Comment 4

[Tony Chung [:tchung]]

moved to evangelism bug--maps.google.com is serving Desktop content with new fennec UA.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Tony Chung [:tchung] from comment #4)
> moved to evangelism bug--maps.google.com is serving Desktop content with new
> fennec UA.

nope, filed bug 736201 for the evangelism part. This bug is for the viewport issue.

Comment 6

[Andreea Pod]

Attachment: screenshot2

Now, when loading maps.google.com the page appears like in the screenshot2. Is this the same issue?

Build: Firefox 14.0a1 (2012-03-18)
Device: LG Optimus 2X (Android 2.2)

Comment 7

[Kartikaya Gupta (email:[e-mail])]

No, that appears to be bug 732016.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

kats was removed as the assignee when this was moved to evangelism and back 2 weeks ago

Comment 10

[Martijn Wargers (dead)]

Bug 732016 is fixed, but this is still an issue.

Comment 11

[JP Rosevear [:jpr]]

Dupe of bug 728026 perhaps?

Comment 12

[Joe Drew (not getting mail)]

Nope, this is strictly viewport related, not clipping.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

This appears to be the same problem as in bug 748526; the content is set to width: 100% and the body has overflow:hidden. This means we lay out the page at 980px width, and don't show anything past screen width (720 px on the Galaxy Nexus).

Unrelated to this, the page intercepts touch events and uses them for panning the map around (which works surprisingly well on the Galaxy Nexus on latest m-c code) so the user can't actually pan or zoom the page. This behaviour is the same on desktop so it's not really a bug.

To fix the viewport issue, there are a couple of options:
1) Get google to insert a meta-viewport header that sets width=device-width on the page.
2) Modify our CSS viewport to match the device width (720px on the Galaxy Nexus). This might be a more "correct" fix but might also break other sites. I will do some investigation as to what web standards say and what other browsers do.

Comment 14

[JP Rosevear [:jpr]]

(In reply to Kartikaya Gupta (:kats) from comment #13)
> This appears to be the same problem as in bug 748526; the content is set to
> width: 100% and the body has overflow:hidden. This means we lay out the page
> at 980px width, and don't show anything past screen width (720 px on the
> Galaxy Nexus).

Is bug 747493 related then as well?

Comment 15

[Kartikaya Gupta (email:[e-mail])]

(In reply to Kartikaya Gupta (:kats) from comment #13)
> This appears to be the same problem as in bug 748526; the content is set to
> width: 100% and the body has overflow:hidden. This means we lay out the page
> at 980px width, and don't show anything past screen width (720 px on the
> Galaxy Nexus).
> 
> Unrelated to this, the page intercepts touch events and uses them for
> panning the map around (which works surprisingly well on the Galaxy Nexus on
> latest m-c code) so the user can't actually pan or zoom the page. This
> behaviour is the same on desktop so it's not really a bug.
> 
> To fix the viewport issue, there are a couple of options:
> 1) Get google to insert a meta-viewport header that sets width=device-width
> on the page.
> 2) Modify our CSS viewport to match the device width (720px on the Galaxy
> Nexus). This might be a more "correct" fix but might also break other sites.
> I will do some investigation as to what web standards say and what other
> browsers do.

Actually, I think I'm completely wrong here. The code doesn't work at all the way I thought it did (even though I was the last person to touch/write the relevant pieces). I will investigate further.

(In reply to JP Rosevear [:jpr] from comment #14)
> Is bug 747493 related then as well?

It might be, too early to tell.

Comment 18

[Alfredos-Panagiotis Damkalis [:fredy]]

Verify that this bug is fixed on nightly (v15 - 18 May). Now you can see the whole page but there is no way to zoom in/out

The bug still affects beta (v14.0b2)

Tested on sgs2 cyanogenmod 9 (ics)

Tested url: http://maps.google.com

Comment 19

[Kartikaya Gupta (email:[e-mail])]

(In reply to Alfredos-Panagiotis Damkalis from comment #18)
> Verify that this bug is fixed on nightly (v15 - 18 May). Now you can see the
> whole page but there is no way to zoom in/out

That is by design; the page intercepts touch events and prevents us from doing zooming.