Closed Bug 750751 Opened 12 years ago Closed 7 years ago

Implement tests for on-wire update format

Categories

(Toolkit :: Safe Browsing, defect, P3)

Product:
Toolkit
Component:
Safe Browsing
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: gcp, Assigned: tnguyen)

References

Details

UrlClassifier / SafeBrowsing tests currently rely for a large part on a custom format for inserting updates for testing. This is very brittle, as illustrated by bug 744993.

The initial code was written and contributed by Google, which presumably could test against their own server. We no longer have that luxury.

We should make a testing setup that is capable of feeding "real" updates to the browser and test on that. This will included a minimal implementation of a SafeBrowsing protocol server.
Product: Firefox → Toolkit
Let's do this in the V4 tests.
Blocks: safebrowsingv4
Priority: -- → P5
Assignee: nobody → hchang
Status: NEW → ASSIGNED
Assignee: hchang → nobody
Status: ASSIGNED → NEW
Priority: P5 → P3
Assignee: nobody → tnguyen
This is the approach we are talking for all new unit tests (including all of the V4 unit tests). We will not re-do the existing V2 tests though.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.