Closed
Bug 763778
Opened 12 years ago
Closed 12 years ago
use PREF_JS_EXPORTS to preprocess/install webapp runtime's default prefs file
Categories
(Firefox Graveyard :: Webapp Runtime, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: myk, Assigned: myk)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
829 bytes,
patch
|
benjamin
:
review+
myk
:
checkin+
|
Details | Diff | Splinter Review |
The build system preprocesses and installs default prefs files specified by PREF_JS_EXPORTS, but the webapp runtime's Makefile doesn't use that macro. It seems like it should, so as not to repeat ourselves, and in case the file ever needs preprocessing. Here's a patch that makes the change.
Attachment #632076 -
Flags: review?(benjamin)
|
Assignee | |
Updated•12 years ago
|
Priority: -- → P3
Target Milestone: --- → Firefox 16
|
||
Updated•12 years ago
|
Attachment #632076 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 1•12 years ago
|
||
Comment on attachment 632076 [details] [diff] [review] patch v1: makes webapprt/Makefile.in use PREF_JS_EXPORTS https://hg.mozilla.org/integration/mozilla-inbound/rev/9191e3007100
Attachment #632076 -
Flags: checkin+
|
||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9191e3007100
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 3•12 years ago
|
||
Looks like an internal code change - no verification needed.
Whiteboard: [qa-]
|
|
||
Updated•12 years ago
|
Flags: in-moztrap-
|
|
||
Updated•12 years ago
|
QA Contact: jsmith
|
||
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•