UI issues when tiles are dragged out of the tab then resize (tiles locked at old size/position)

NEW
Unassigned

Status

()

defect
5 years ago
4 years ago

People

(Reporter: cornel_ionce, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox30 wontfix, firefox31- wontfix, firefox32- affected, firefox33- affected, firefox35 affected, firefox36 affected, firefox-esr31+ wontfix)

Details

()

Attachments

(1 obsolete attachment)

User Agents:
Mozilla/5.0 (Windows NT 6.3; rv:31.0) Gecko/20100101 Firefox/31.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Firefox/31.0

Build ID: 20140422030204

While verifying bug 994185 I've encountered some issues for the Newtab page tiles. I've attached a video showing them.

STR:
1. Open Firefox.
2. Open a new tab or go to about:newtab.
3. Resize the window until one row/column disappear.
4. Drag the last downwards, under the last row.

Results:
- several issues can be seen; tiles will overlap into the last position.
- scrollbars are shown.
- after maximizing the window, the tiles are misplaced.

Notes:
This started to reproduce on 2014-03-26 Nightly, when the fix for 980014 landed.
Added the video to the URL, could not attach it due to it's size.
Blocks: tiles-dev
Component: Tabbed Browser → General
Flags: firefox-backlog?
Flags: firefox-backlog? → firefox-backlog+
Component: General → New Tab Page
> This started to reproduce on 2014-03-26 Nightly, when the fix for 980014 landed.

Marking this is a regression from bug 980014. Based on what I've seen this is a bit of an edge-case so I don't think this should block the feature from shipping. However we should address this in Firefox 32 Beta if possible. We should also pay attention to user feedback in release in case we need to pref this off if it becomes explosively negative.
Wontfix for 31 but it is low risk, we could take a patch for ESR31.

Comment 4

5 years ago
Posted patch v1 backout (obsolete) — Splinter Review

Updated

5 years ago
Depends on: 1038997
Ed - I think we want a separate backout bug as this bug will still need to be fixed on 32.
Flags: needinfo?(edilee)

Comment 6

5 years ago
Comment on attachment 8456446 [details] [diff] [review]
v1 backout

Created bug 1038997 for the beta backout.
Attachment #8456446 - Attachment is obsolete: true
Flags: needinfo?(edilee)
Not a regression: 30 was affected too...
The overlapping tiles here was caused by something other than bug 980014 since I can reproduce this in Firefox 30. Cornel, I think this needs further testing and each issue should be broken out into their own bug. We need to figure out when each individual issue regressed (if they are indeed regressions).

FWIW, I think this investigation should occur in parallel to releasing Firefox 31 as is.
No longer blocks: 980014

Comment 9

5 years ago
ashughes helped explain how to reproduce this on 31RC2 and 30; and because it reproduces on 30, it's not a regression from bug 980014.

The simplest STR:
1) make sure there's at least 2 tiles on the newtab page
2) drag a tile out of the window to another window (console, text, browser, etc.)
3) resize the window and see some tiles locked at the before-resize size

My best guess right now is that step 2 initiates a drag but doesn't trigger the end of the drag, so that newtab page still marks the tiles as "locked" (in position and size).
No longer blocks: tiles-dev
No longer depends on: 1038997
Summary: UI issues when the window is resized until 2x3/3x2 grid is displayed → UI issues when tiles are dragged out of the tab then resize (tiles locked at old size/position)
Not a regression, and only visible in certain unusual dragging scenarios - I think we shouldn't be tracking this for upcoming releases.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20100101 Firefox/13.0

After further investigations I've notice that these issues started to reproduce way back to Firefox 13 (build ID: 20120601045813), when the Tile Grid was introduced on the New Page.

Updated

5 years ago
Depends on: 1068354
I'm working on bug 1068354
the mozregession is the same, so I will put this information here aswell.

2013-07-24 = bad
2013-07-23 = good

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5ceea82a79c7&tochange=a4c1961bf723

Updated

5 years ago
Blocks: 894345
No longer tracking this as it doesn't meet criteria and has shipped with little impact to our users.

Updated

4 years ago
Duplicate of this bug: 1174561
Comment hidden (obsolete)
You need to log in before you can comment on or make changes to this bug.