Closed Bug 994185 Opened 6 years ago Closed 6 years ago

When dragging tiles on a 3x2 view, a third row of tiles shows up inexplicably

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 31
Tracking Status
firefox31 + verified

People

(Reporter: jaws, Assigned: Mardak)

References

Details

(Whiteboard: p=3 s=it-31c-30a-29b.3 [qa!])

Attachments

(1 file, 3 obsolete files)

STR:
Resize the browser to only show two rows of three tiles
Drag one of the tiles

ER:
Still, only 2 rows of tiles are shown on screen

AR:
A third row of tiles appears
Flags: firefox-backlog?
With some quick testing, the 3rd row only appears while the the pointer is over the grid, so if you start a drag and point to the empty space to the sides, the 3rd row disappears.

I would guess that it's:

.newtab-site[frozen] {
  position: absolute;

Where the hiding of the 3rd row happens with:

#newtab-grid {
  overflow: hidden;
Flags: firefox-backlog? → firefox-backlog+
Whiteboard: p=0
I also see the third row appear and disappear if I click the [x] on any of the tiles.
One simple hack that doesn't involve complicated node hierarchy changes is to set the bottom spacer/#newtab-margin-bottom to be the same background color as #newtab-scrollbox while also position: relative.
Gijs, Do you think this needs tracking at this time?
Flags: needinfo?(gijskruitbosch+bugs)
Yes, it does.
Flags: needinfo?(gijskruitbosch+bugs)
Attached patch v1 (obsolete) — Splinter Review
This takes some code from bug 962490 although this patch by itself would not vertically center the grid. If this lands after the search bug, it'll be more correct with fewer changes.
Attachment #8409139 - Flags: review?(adw)
Assignee: nobody → edilee
Blocks: 980014
Whiteboard: p=0 → p=3 s=it-31c-30a-29b.3
Status: NEW → ASSIGNED
Whiteboard: p=3 s=it-31c-30a-29b.3 → p=3 s=it-31c-30a-29b.3 [qa?]
Attached patch v2 (obsolete) — Splinter Review
Correctly vertically centers by switching both spacers to div flex.
Attachment #8409139 - Attachment is obsolete: true
Attachment #8409139 - Flags: review?(adw)
Attachment #8409174 - Flags: review?(adw)
Attached patch v3 (obsolete) — Splinter Review
Only color background when not disabled
Attachment #8409174 - Attachment is obsolete: true
Attachment #8409174 - Flags: review?(adw)
Attachment #8409183 - Flags: review?(adw)
Attachment #8409183 - Flags: review?(adw) → review+
Attached patch v4Splinter Review
Incorporates some of the changes from bug 962490 to anchor the undo box above the grid as opposed to anchored to the top of the page.
Attachment #8409213 - Flags: review?(adw)
Attachment #8409213 - Attachment description: for-check-in front-end patch v4 → v4
Comment on attachment 8409213 [details] [diff] [review]
v4

Review of attachment 8409213 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8409213 - Flags: review?(adw) → review+
Attachment #8409183 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/f1ad078b79e5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Hi Liz, can you review this bug to determine if it requires further QA verification [qa+] or not [qa-].
Flags: needinfo?(lhenry)
Tracy, is this your feature or Cornel's? I would call it qa+.
Flags: needinfo?(lhenry)
QA Contact: twalker
Whiteboard: p=3 s=it-31c-30a-29b.3 [qa?] → p=3 s=it-31c-30a-29b.3 [qa+]
It would belong to QA owner of 31, SV may have someone assigned to tiles. But yes seems QA+.
QA Contact: twalker
QA Contact: cornel.ionce
Hi Cornel, confirming if this resolved bug can be verified before the end of the desktop iteration on Monday April 28?
Flags: needinfo?(cornel.ionce)
I can confirm the fix for this issue using latest Nightly (build ID: 20140326030203) on Windows 7 64bit, Windows 8.1 32bit, Ubuntu 12.04 and Mac OS X 10.9.2.

The third row isn't displayed anymore as mentioned in comment 0; I've logged bug 1000097 for some issues spotted.
Status: RESOLVED → VERIFIED
Flags: needinfo?(cornel.ionce)
Whiteboard: p=3 s=it-31c-30a-29b.3 [qa+] → p=3 s=it-31c-30a-29b.3 [qa!]
You need to log in before you can comment on or make changes to this bug.