994185 - When dragging tiles on a 3x2 view, a third row of tiles shows up inexplicably

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
Resize the browser to only show two rows of three tiles
Drag one of the tiles

ER:
Still, only 2 rows of tiles are shown on screen

AR:
A third row of tiles appears

Comment 1

[Ed Lee :Mardak]

With some quick testing, the 3rd row only appears while the the pointer is over the grid, so if you start a drag and point to the empty space to the sides, the 3rd row disappears.

I would guess that it's:

.newtab-site[frozen] {
  position: absolute;

Where the hiding of the 3rd row happens with:

#newtab-grid {
  overflow: hidden;

Comment 2

[Ed Lee :Mardak]

This might be relevant ? http://stackoverflow.com/questions/2243245/css-how-to-have-positionabsolute-div-inside-a-positionrelative-div-not-be-cro

Comment 3

[:Gijs (he/him)]

I also see the third row appear and disappear if I click the [x] on any of the tiles.

Comment 4

[Ed Lee :Mardak]

One simple hack that doesn't involve complicated node hierarchy changes is to set the bottom spacer/#newtab-margin-bottom to be the same background color as #newtab-scrollbox while also position: relative.

Comment 5

[Benjamin Kerensa [:bkerensa]]

Gijs, Do you think this needs tracking at this time?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Yes, it does.

Comment 7

[Ed Lee :Mardak]

Attachment: v1

This takes some code from bug 962490 although this patch by itself would not vertically center the grid. If this lands after the search bug, it'll be more correct with fewer changes.

Comment 8

[Ed Lee :Mardak]

Attachment: v2

Correctly vertically centers by switching both spacers to div flex.

Comment 9

[Ed Lee :Mardak]

Attachment: v3

Only color background when not disabled

Comment 10

[Ed Lee :Mardak]

Attachment: v4

Incorporates some of the changes from bug 962490 to anchor the undo box above the grid as opposed to anchored to the top of the page.

Comment 11

[Drew Willcoxon :adw]

Comment on attachment 8409213 [details] [diff] [review]
v4

Review of attachment 8409213 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 12

[Ed Lee :Mardak]

https://hg.mozilla.org/integration/fx-team/rev/f1ad078b79e5
Also fixes bug 988907.

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f1ad078b79e5

Comment 14

[Marco Mucci [:MarcoM]]

Hi Liz, can you review this bug to determine if it requires further QA verification [qa+] or not [qa-].

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracy, is this your feature or Cornel's? I would call it qa+.

Comment 16

[Tracy Walker [:tracy]]

It would belong to QA owner of 31, SV may have someone assigned to tiles. But yes seems QA+.

Comment 17

[Marco Mucci [:MarcoM]]

Hi Cornel, confirming if this resolved bug can be verified before the end of the desktop iteration on Monday April 28?

Comment 18

[Cornel Ionce [:noni] [Hubs QA]]

I can confirm the fix for this issue using latest Nightly (build ID: 20140326030203) on Windows 7 64bit, Windows 8.1 32bit, Ubuntu 12.04 and Mac OS X 10.9.2.

The third row isn't displayed anymore as mentioned in comment 0; I've logged bug 1000097 for some issues spotted.