1000130 - Clean up bootstrap mozL10n API use in Gallery

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Staś Małolepszy :stas]

Gallery currently sets document's lang/dir and uses 'localized' event to initialize.

Instead it should use mozL10n.once.

Comment 1

[Staś Małolepszy :stas]

Attachment: Use mozL10n.once

https://github.com/mozilla-b2g/gaia/pull/18584

Comment 2

[David Flanagan [:djf]]

Comment on attachment 8411146 [details] [diff] [review]
Use mozL10n.once

The code looks good to me, and seems to work correctly. In particular, I've tested the open activity.

I still have my fundamental lack of understanding of whether we're waiting for an onload event here, however.

Comment 3

[Staś Małolepszy :stas]

(In reply to David Flanagan [:djf] from comment #2)

> I still have my fundamental lack of understanding of whether we're waiting
> for an onload event here, however.

We're not.  As I mentioned in the other bugs, I'll wait until bug 1000806 is fixed before I move forward here.  The patch works but I'm worried that it might cause race conditions under some rare circumstances.  I'm sorry for the trouble.

Comment 4

[Staś Małolepszy :stas]

Attachment: Use mozL10n.once, remove languageDirection

As concluded in bug 1000806, as long as mozL10n.ready and .once are called in deferred scripts, it is safe to assume that the callback will have access to an interactive DOM.  This is the case here.

I rebased the pull request and also made one more small change to js/frames.js.  Namely, I removed languageDirection in favor of navigator.mozL10n.language.direction.

Carrying over the r+.  I'll wait for Travis before landing.

Comment 5

[Staś Małolepszy :stas]

Builds:

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=46272a0f7bb6
https://travis-ci.org/mozilla-b2g/gaia/builds/26753184

Comment 6

[Staś Małolepszy :stas]

Commit: https://github.com/mozilla-b2g/gaia/commit/d02cf4cbfa179f7bfe1f745a70367d92c1349c26
Merged: https://github.com/mozilla-b2g/gaia/commit/17ad812558d417c6b6121a3058440bd1e0f276b7