Closed
Bug 1000172
Opened 11 years ago
Closed 11 years ago
[Settings] Prevent the scripts defining global objects from being merged during script optimization
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arthurcc, Assigned: arthurcc)
References
Details
Attachments
(1 file)
Currently we use requirejs shim for legacy objects existed in the global scope. The original files will be removed during the optimization and make the objects unable to be accessed by reference.
We should prevent those files from the optimization process by modifying settings.build.jslike.
|
Assignee | |
Comment 1•11 years ago
|
||
Fred, George, could you check if this makes sense to you? Thanks.
Attachment #8411027 -
Flags: feedback?(gduan)
Attachment #8411027 -
Flags: feedback?(gasolin)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8411027 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18587
Nice!
Reference: http://requirejs.org/docs/optimization.html#empty
Attachment #8411027 -
Flags: feedback?(gduan) → feedback+
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8411027 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18587
looks good to me
Attachment #8411027 -
Flags: feedback?(gasolin) → feedback+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8411027 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18587
Evelyn, could you rubber stamp on this patch? Thanks.
Attachment #8411027 -
Flags: review?(ehung)
|
||
Updated•11 years ago
|
Attachment #8411027 -
Flags: review?(ehung) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Thanks all!
master: 590788dc7a88b9d9b1f98f1d0da5447c4616f557
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•