Closed
Bug 1000207
Opened 10 years ago
Closed 10 years ago
upload flame gecko/gaia mars to public ftp
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(3 files)
524 bytes,
patch
|
mozilla
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
503 bytes,
patch
|
mozilla
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
49 bytes,
text/x-github-pull-request
|
mwu
:
review+
dhylands
:
review+
|
Details | Review |
I was going to test this on try, but we don't have builders there. I think it's safe enough to not warrant spending 2-3h waiting for a staging build.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8411036 -
Flags: review?(aki)
Updated•10 years ago
|
Attachment #8411036 -
Flags: review?(aki) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8411036 [details] [diff] [review] upload flame mar https://hg.mozilla.org/mozilla-central/rev/b5395baf5883 16:47 < bhearsum> flame-only, just adds an extra file to the upload 16:47 < RyanVM> tell you waht, just push it to m-c DONTBUILD 16:47 < RyanVM> i'll be merging m-c back around soon anyway 16:48 < bhearsum> fine with me, as long as you're ok with me not being around until its builds finish 16:48 < RyanVM> DONTBUILD 16:48 < RyanVM> :) 16:48 < bhearsum> :) 16:48 < RyanVM> you weren't going to get quick builds anyway 16:48 < RyanVM> Flame is periodic 16:48 < bhearsum> oh, right 16:48 < bhearsum> thanks, much appreciated 16:49 < RyanVM> np
Attachment #8411036 -
Flags: checked-in+
Assignee | ||
Comment 3•10 years ago
|
||
With this landed, we should get MARs uploaded for the next Flame nightlies \o/
Assignee | ||
Comment 5•10 years ago
|
||
So this worked, but we end up with files like http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/2014-04-24-04-02-01-mozilla-central/b2g-gecko-update.mar, which is going to be a problem when we have multiple devices doing it. I think we probably need to adjust the file names for these mars...
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Ben Hearsum [:bhearsum] from comment #5) > So this worked, but we end up with files like > http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/2014-04-24-04-02-01- > mozilla-central/b2g-gecko-update.mar, which is going to be a problem when we > have multiple devices doing it. I think we probably need to adjust the file > names for these mars... That stuff is defined over at https://github.com/mozilla-b2g/gonk-misc/blob/master/Android.mk#L220. Maybe we can put $(PRODUCT_MODEL) in UPDATE_PACKAGE_TARGET? Not sure if that's going to be accessible or not.
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Ben Hearsum [:bhearsum] from comment #6) > (In reply to Ben Hearsum [:bhearsum] from comment #5) > > So this worked, but we end up with files like > > http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/2014-04-24-04-02-01- > > mozilla-central/b2g-gecko-update.mar, which is going to be a problem when we > > have multiple devices doing it. I think we probably need to adjust the file > > names for these mars... > > That stuff is defined over at > https://github.com/mozilla-b2g/gonk-misc/blob/master/Android.mk#L220. Maybe > we can put $(PRODUCT_MODEL) in UPDATE_PACKAGE_TARGET? Not sure if that's > going to be accessible or not. I tried this out by hand and it looks like $(PRODUCT_MODEL) works. That's probably good enough for now. Here's a patch to be less fussy about the filename of the mar we upload. I'll need to make a PR to gonk-misc to change the filename, I guess.
Attachment #8412629 -
Flags: review?(aki)
Assignee | ||
Comment 8•10 years ago
|
||
I think comment #5 and the pull request have all of the relevant info - let me know if you have any questions.
Attachment #8412639 -
Flags: review?(mwu)
Updated•10 years ago
|
Attachment #8412629 -
Flags: review?(aki) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8412629 [details] [diff] [review] upload any mar in b2g-update https://hg.mozilla.org/mozilla-central/rev/3d8e8213e08e
Attachment #8412629 -
Flags: checked-in+
Comment 10•10 years ago
|
||
Comment on attachment 8412639 [details] [review] include $(PRODUCT_MODEL) in mar name I agree with dhylands WRT the variables - PRODUCT_MODEL isn't what we want.
Attachment #8412639 -
Flags: review?(mwu)
Assignee | ||
Comment 11•10 years ago
|
||
OK, so bug 1001542 is fixed but I don't think that affected anything here, as it turns out. Should we just use $(PRODUCT_DEVICE) in the mar name instead, since that what we'll use in the update URL?
Flags: needinfo?(mwu)
Flags: needinfo?(dhylands)
Comment 12•10 years ago
|
||
Yeah. I think $(TARGET_DEVICE) is actually a little bit more correct in this case, so use that if it works.
Flags: needinfo?(mwu)
Assignee | ||
Comment 13•10 years ago
|
||
Looks like $(TARGET_DEVICE) works. I ended up with b2g-flame-gecko-update.mar, which sounds right to me. I'll send a new pull request.
Flags: needinfo?(dhylands)
Assignee | ||
Comment 14•10 years ago
|
||
Comment on attachment 8412639 [details] [review] include $(PRODUCT_MODEL) in mar name I updated this pull request to use $(TARGET_DEVICE).
Attachment #8412639 -
Flags: review?(mwu)
Attachment #8412639 -
Flags: review?(dhylands)
Comment 15•10 years ago
|
||
Comment on attachment 8412639 [details] [review] include $(PRODUCT_MODEL) in mar name Looks fine, though you should probably rebase your patch so the merge is a bit cleaner.
Attachment #8412639 -
Flags: review?(mwu) → review+
Assignee | ||
Comment 16•10 years ago
|
||
(In reply to Michael Wu [:mwu] from comment #15) > Comment on attachment 8412639 [details] [review] > include $(PRODUCT_MODEL) in mar name > > Looks fine, though you should probably rebase your patch so the merge is a > bit cleaner. Done
Assignee | ||
Comment 17•10 years ago
|
||
Ack - please hold off on merging this for now. I just discovered that our build scripts hardcode "b2g-gecko-update.mar".
Comment 18•10 years ago
|
||
Comment on attachment 8412639 [details] [review] include $(PRODUCT_MODEL) in mar name When you do a build, stuff shows up in out/target/product/$(TARGET_DEVICE)/... so this feels like the right variable to use. Although this is probably going to break a bunch of other things. So I think that before we land this, we need to find all of the places which have b2g-gecko-update.mar hard-coded in them. I don't know which scripts releng and QA use for creating updates and whether any of those depend on this name.
Attachment #8412639 -
Flags: review?(dhylands) → review+
Assignee | ||
Comment 19•10 years ago
|
||
(In reply to Dave Hylands [:dhylands] (away - back May 16) from comment #18) > So I think that before we land this, we need to find all of the places which > have b2g-gecko-update.mar hard-coded in them. > > I don't know which scripts releng and QA use for creating updates and > whether any of those depend on this name. I've got a patch waiting on review in bug 1000208 to fix the build script to be compatible with both styles. Looks like there's at least one QA test that needs fixing: http://mxr.mozilla.org/mozilla-central/source/testing/marionette/update-smoketests/stage-update.py#32. I'll get in contact with them to make sure there's nothing else.
Assignee | ||
Comment 20•10 years ago
|
||
(In reply to Ben Hearsum [:bhearsum] from comment #19) > (In reply to Dave Hylands [:dhylands] (away - back May 16) from comment #18) > > So I think that before we land this, we need to find all of the places which > > have b2g-gecko-update.mar hard-coded in them. > > > > I don't know which scripts releng and QA use for creating updates and > > whether any of those depend on this name. > > I've got a patch waiting on review in bug 1000208 to fix the build script to > be compatible with both styles. > > Looks like there's at least one QA test that needs fixing: > http://mxr.mozilla.org/mozilla-central/source/testing/marionette/update- > smoketests/stage-update.py#32. I'll get in contact with them to make sure > there's nothing else. Jeff, I'm told you're the person to ask about this script. Do you know if it's still in use and if there's anything else that relies on "b2g-gecko-update.mar" as a name (either in dist/ or on FTP/pvtbuilds).
Flags: needinfo?(jgriffiths)
Comment 21•10 years ago
|
||
I'm really sure you mean someone else ( I work as a PM on Devtools )
Flags: needinfo?(jgriffiths)
Comment 23•10 years ago
|
||
So, that particular test hasn't been run for 6+ months, and would likely need considerable TLC before it could run again. I don't know of anything else that relies on that filename.
Flags: needinfo?(jgriffin)
Assignee | ||
Comment 24•10 years ago
|
||
(In reply to Jonathan Griffin (:jgriffin) from comment #23) > So, that particular test hasn't been run for 6+ months, and would likely > need considerable TLC before it could run again. I don't know of anything > else that relies on that filename. OK, so once my patch from 1000208 lands in production (probably later today), we should be able to merge the pull request. I'll update the bug when we're clear.
Assignee | ||
Comment 25•10 years ago
|
||
OK, this can be merged anytime now. Dave, can you do that?
Flags: needinfo?(dhylands)
Comment 26•10 years ago
|
||
https://github.com/mozilla-b2g/gonk-misc/commit/abedd83e1ba61cb83e59c723ad6279ad2a7aa1d1
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(dhylands)
Resolution: --- → FIXED
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•