1000324 - Explicitly signal B2G get_about_memory.py on completion of GC/CC logging.

Status: RESOLVED WONTFIX

(Toolkit :: about:memory, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Once bug 973090 lands, it will be possible to know when all child processes have finished writing GC/CC logs (or crashed in the process, causing actor destruction).  If we report this to the B2G get_about_memory.py script, then it can safely overestimate the number of log files to wait for; in particular, this means that MOZ_IGNORE_NUWA_PROCESS will be unnecessary.

(The script will need to remain compatible with older geckos, so it will still need to count log files, and cannot underestimate.)

Comment 1

[Eric Rahm [:erahm]]

Jed, how were you thinking about signalling this?

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Eric Rahm [:erahm] from comment #1)
> Jed, how were you thinking about signalling this?

Creating an empty file next to the log files, probably.  The code that handles the "unified-memory-report" file is almost the right thing, but in this case the data remains in the non-"unified" file so it might want a name change.

(Longer-term it would be nice to connect this through the devtools protocol instead of poking at the filesystem, but I don't think that needs to hold up making progress on this.)