1057565 - Get rid of |MOZ_IGNORE_NUWA_PROCESS|

Status: RESOLVED FIXED

(Toolkit :: about:memory, defect)

Description

[Eric Rahm [:erahm]]

The undocumented, but required, env var should be replaced w/ automatic Nuwa detection.

We can do this by simply grepping the b2g-ps output for 'Nuwa'.

Note: Bug 1000324 seeks to fix this in a more elegant way by signalling when GC/CC logging is completed, but we still need a better solution for older releases.

Comment 1

[Eric Rahm [:erahm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/379

This still preserves the ability to override with MOZ_IGNORE_NUWA_PROCESS=1, but otherwise dynamically checks for a Nuwa process.

Comment 2

[Nicholas Nethercote [inactive]]

+1

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

If I recall correctly, the reason this wasn't done originally is that there's a hope that, some day, Nuwa would be able to participate in memory reporting, and decrementing the process count would be wrong for the versions of Gecko after that.  khuey might know more.

Comment 4

[Nicholas Nethercote [inactive]]

> If I recall correctly, the reason this wasn't done originally is that
> there's a hope that, some day, Nuwa would be able to participate in memory
> reporting, and decrementing the process count would be wrong for the
> versions of Gecko after that.

And when that day comes, this can be fixed.

A pet peeve of mine is software that has --make-it-actually-work flags. This is a perfect example.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8477690 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/379

r=me

Please send email to dev-b2g when this lands.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/B2G/commit/e6d4530ee0783adf60ad193b8bb39b94958f2a38